[data] Extract @kbn/field-types to a package #106973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
Feature:FieldFormatters
Team:AppServices
v7.15.0
v8.0.0
release_note:plugin_api_changes
…-package # Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md # docs/development/plugins/data/server/kibana-plugin-plugins-data-server.md
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
lizozom
approved these changes
Jul 28, 2021
| @@ -0,0 +1,89 @@ | |||
|
|
|||
| load("@npm//@bazel/typescript:index.bzl", "ts_config", "ts_project") | |||
There was a problem hiding this comment.
Think it could be a good idea to have someone from @elastic/kibana-operations review this. What do you say?
| } from '@kbn/field-types'; | ||
|
|
||
| /** | ||
| * @deprecated import from "@kbn/field-types" instead |
There was a problem hiding this comment.
I think it could be nice if we use identical messages across Kibana.
Maybe align with the format I started (or change to yours if you prefer).
There was a problem hiding this comment.
I agree, I made this message a bit nicer and add @removeBy tag.
We need to add a @removeBy tag and change kbn/es-query -> @kbn/es-query in other messages, but I don't want to do this in this pr. I would prefer a separate pr instead. There we can also align those.
There was a problem hiding this comment.
I made #107175
Mind reviewing?
9 tasks
mistic
approved these changes
Jul 29, 2021
mattkime
approved these changes
Jul 29, 2021
|
@elasticmachine merge upstream |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 30, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jul 30, 2021
4 tasks
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_view_mode·js.dashboard mode Dashboard View Mode Dashboard viewer "before all" hook: Create dashboard only mode user for "shows only the dashboard app link"Standard OutStack TraceKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·js.security app users should show the default rolesStandard OutStack TraceKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·js.security app users should show the default rolesStandard OutStack TraceMetrics [docs]Module Count
Public APIs missing comments
Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Needed for #106966
This extracts leaf
kbn_field_typesutils and types to a package so that we can break out field formats and index patterns from data.I re-exported the package from data plugin and marked old exports as deprecated where it doesn't hurt. I converted only imports inside
field formatscode so we have fewer changes in #106966Checklist
Plugin API changes
kbn_field_typeswere extracted fromdataplugin into a separate package@kbn/field-types