[6.8] Remove unused dependency apollo-server-hapi

[watson]

This dependency doesn't seem to be used anywhere in our code-base. It could be that it's somehow magically required in a dynamic fashion - hopefully CI will complain if that's the case.

This dependency was originally added in #24068 - however, even in that PR the apollo-server-hapi module wasn't referenced anywhere in the code-base. So maybe even then it was a mistake?

@weltenwort I hope you don't mind that I'm requesting a review from you since you originally created #24068 - so hopefully you can shed some light on this 😅

[watson]

From the failing tests, it seems that we were actually depending on some of the sub-dependencies of apollo-server-hapi to be installed, which now that this module is removed are no longer installed. Normally in Node.js land this isn't recommended, but maybe the Apollo ecosystem does it this way?

Until I know better, I'll try to update this PR by adding direct dependencies to the modules that we do require instead.

[weltenwort]

Took me a while to realize this is the 6.x codebase 🙈 I remember something about a package update that broke the official integration between apollo and hapi. I suspect it was at that point that we stopped using apollo-server-hapi directly and re-implemented a custom integration layer. Your strategy of instead depending on its dependencies directly sounds reasonable to me:

https://github.com/apollographql/apollo-server/blob/b32e89c06008719d2fb45e5e22a767625ea13c0a/packages/apollo-server-hapi/package.json#L27-L30

[watson]

@weltenwort Sorry for not stating that clearly 😅 I've updated the title now to include [6.8]

And thanks for looking into this 👍

I opened this PR originally because I wanted to either upgrade or get rid of apollo-server-core. If I can get your 👍 in a review, then I'll merge this as is and open another PR where I then try to upgrade apollo-server-core.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 59b1447

History

• 💔 Build #141395 failed e847fe48611e0c5b76aa5903c9fc3594efc61994

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[weltenwort]

Thank you!