Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to named export conversion: Courier #11165

Merged
merged 2 commits into from
Apr 13, 2017

Conversation

stacey-gammon
Copy link
Contributor

@stacey-gammon stacey-gammon commented Apr 11, 2017

Convert default to named in ui/public/courier/*

@stacey-gammon
Copy link
Contributor Author

@tylersmalley - any chance you can get to this today? If not I can look for someone else to tag.

@tylersmalley
Copy link
Contributor

@stacey-gammon - yes, I will get to this today. Sorry for the delay.

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and great job with the naming consistently!

@stacey-gammon stacey-gammon merged commit 945316c into elastic:master Apr 13, 2017
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Apr 13, 2017
* Default to named export conversion: Courier - Part 1

* Part 2
stacey-gammon added a commit that referenced this pull request Apr 14, 2017
* Default to named export conversion: Courier - Part 1

* Part 2
@stacey-gammon stacey-gammon deleted the default-to-named-courier branch October 24, 2017 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants