[Workplace Search] Remove unused components and redundant link #112971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are no longer needed after the removal of Standard Auth
yakhinvadim
changed the title
yakhinvadim
changed the title
It duplicates the link below the image and creates a redundant "external link" icon
yakhinvadim
force-pushed
the
design-pass
branch
from
2b6ebdf to
1e6b3f2
Compare
|
@elasticmachine merge upstream |
yakhinvadim
added
auto-backport
scottybollinger
approved these changes
Sep 23, 2021
ryankeairns
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
SCSS file deleted.
@zombieFox be on the lookout for these PRs that auto-ping ent-search-design. The trigger is any change to a SASS file so, at minimum, give that a quick look.
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 27, 2021
…ic#112971) * Remove user_icon and user_option_item components They are no longer needed after the removal of Standard Auth * Remove link wrapping image It duplicates the link below the image and creates a redundant "external link" icon * Fix typo Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 27, 2021
…) (#113138) * Remove user_icon and user_option_item components They are no longer needed after the removal of Standard Auth * Remove link wrapping image It duplicates the link below the image and creates a redundant "external link" icon * Fix typo Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Vadim Yakhin <yakhin.v@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes all non-opinionated fixes from the design pass issue.
There are two main fixes here:
Closes https://github.com/elastic/workplace-search-team/issues/1937