Updates APM defaults and CI settings #117749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added
Team:Operations
tylersmalley
requested review from
vigneshshanmugam and
a team
as code owners
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
commented
Nov 5, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
update-apm-settings
branch
from
30e0cb3 to
bcd75b0
Compare
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
lizozom
approved these changes
Nov 7, 2021
| captureBody: 'off', | ||
| captureHeaders: false, | ||
| breakdownMetrics: false, | ||
| metricsInterval: '120s', | ||
| transactionSampleRate: 0.1, |
There was a problem hiding this comment.
I love that transactionSampleRate can be also overridden from an env var
| captureBody: 'off', | ||
| captureHeaders: false, | ||
| breakdownMetrics: false, | ||
| metricsInterval: '120s', |
There was a problem hiding this comment.
@mshustov mentioned adding propagateTracestate?
If we make sure CORS is properly enabled on our server, we could enable it here too?
There was a problem hiding this comment.
propagateTracestate: true should work out of the box for API calls to the Kibana server
jbudz
approved these changes
Nov 8, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
|
@elasticmachine merge upstream |
tylersmalley
added
the
auto-backport
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
7 tasks
added 4 commits
November 18, 2021 16:10
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
💛 Build succeeded, but was flaky
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 23, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 23, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Nov 24, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 24, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
10 tasks
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the default APM server to use that which we have for production use. Our APM cluster for CI is now being set only for CI to ensure they are separate.
Closes #116496