-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Surfacing deprecations with rich context from ES warning header #120109
Conversation
e3c7ae9
to
270ed4e
Compare
9885fbb
to
3d793d7
Compare
@rudolf is this intended to be merged? I would like to see if any deprecation stacktraces are coming from fleet plugin. |
add8b9d
to
45ecde2
Compare
2b6c7e0
to
5374ac7
Compare
const txt = format(msg.args[0], ...msg.args.slice(1)); | ||
// Ensure that Elasticsearch deprecation log messages from Kibana aren't ignored | ||
if (/\[deprecation\]\[elasticsearch\]/.test(txt)) { | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returning true
here isn't enough, it needs to get to the ToolingLogTextWriter.write()
call below for true
to actually mean "I wrote the message"
This reverts commit ed0e08b.
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This work has been backported to 7.16 in #120882 |
Summary
Backport #120044 on 7.16 since I couldn't see any deprecation logs on main to verify that it works.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers