Use es6 exports, replace module.exports #12084

w33ble · 2017-05-30T21:35:11Z

There's a lot of places in Kibana where module.exports is still used, despite our having moved to es6 modules a while ago. This causes problems when static analyzers try to resolve those exports.

This PR is the result of using the exports transform from 5to6-codemod, and a little manual cleanup.

Since this change basically equates to using export default, there's a conflict with our kibana-custom/no-default-export eslint rule. I wanted to keep the scope of this PR down and avoid larger refactoring, so I added exceptions to the code. We can always clean them up in another PR.

spalger

LGTM, CI passes and changes look good after a good skim. 🛳

tylersmalley · 2017-06-02T00:24:49Z

I am getting an error building when not in dev mode

  log   [00:22:17.871] [info][optimize] Optimizing and caching bundles for kibana, stateSessionStorageRedirect, timelion, sense-tests and status_page. This may take a few minutes
  log   [00:22:59.717] [fatal] Error: Optimizations failure.

    ERROR in kibana.bundle.js from UglifyJs
    SyntaxError: Name expected [kibana.bundle.js:89156,5]

    ERROR in timelion.bundle.js from UglifyJs
    SyntaxError: Name expected [timelion.bundle.js:88897,5]

    at Object.exports.create (/Users/tyler/elastic/kibana/node_modules/boom/lib/index.js:21:17)
    at FsOptimizer.failedStatsToError (/Users/tyler/elastic/kibana/src/optimize/base_optimizer.js:224:17)
    at /Users/tyler/elastic/kibana/src/optimize/fs_optimizer.js:17:26
    at Compiler.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compiler.js:181:13)
    at /Users/tyler/elastic/kibana/node_modules/webpack/lib/Compiler.js:403:12
    at Compiler.next (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:67:11)
    at Compiler.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/CachePlugin.js:40:4)
    at Compiler.applyPluginsAsync (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:71:13)
    at Compiler.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compiler.js:400:9)
    at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compilation.js:577:13)
    at Compilation.applyPluginsAsync (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:60:69)
    at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compilation.js:572:10)
    at Compilation.next (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:67:11)
    at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/optimize/UglifyJsPlugin.js:140:4)
    at Compilation.applyPluginsAsync (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:71:13)
    at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compilation.js:567:9)
FATAL { Error: Optimizations failure.

    ERROR in kibana.bundle.js from UglifyJs
    SyntaxError: Name expected [kibana.bundle.js:89156,5]

    ERROR in timelion.bundle.js from UglifyJs
    SyntaxError: Name expected [timelion.bundle.js:88897,5]

    at Object.exports.create (/Users/tyler/elastic/kibana/node_modules/boom/lib/index.js:21:17)
    at FsOptimizer.failedStatsToError (/Users/tyler/elastic/kibana/src/optimize/base_optimizer.js:224:17)
    at /Users/tyler/elastic/kibana/src/optimize/fs_optimizer.js:17:26
    at Compiler.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compiler.js:181:13)
    at /Users/tyler/elastic/kibana/node_modules/webpack/lib/Compiler.js:403:12
    at Compiler.next (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:67:11)
    at Compiler.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/CachePlugin.js:40:4)
    at Compiler.applyPluginsAsync (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:71:13)
    at Compiler.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compiler.js:400:9)
    at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compilation.js:577:13)
    at Compilation.applyPluginsAsync (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:60:69)
    at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compilation.js:572:10)
    at Compilation.next (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:67:11)
    at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/optimize/UglifyJsPlugin.js:140:4)
    at Compilation.applyPluginsAsync (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:71:13)
    at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compilation.js:567:9)
  cause:
   { Error: Optimizations failure.

       ERROR in kibana.bundle.js from UglifyJs
       SyntaxError: Name expected [kibana.bundle.js:89156,5]

       ERROR in timelion.bundle.js from UglifyJs
       SyntaxError: Name expected [timelion.bundle.js:88897,5]

       at Object.exports.create (/Users/tyler/elastic/kibana/node_modules/boom/lib/index.js:21:17)
       at FsOptimizer.failedStatsToError (/Users/tyler/elastic/kibana/src/optimize/base_optimizer.js:224:17)
       at /Users/tyler/elastic/kibana/src/optimize/fs_optimizer.js:17:26
       at Compiler.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compiler.js:181:13)
       at /Users/tyler/elastic/kibana/node_modules/webpack/lib/Compiler.js:403:12
       at Compiler.next (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:67:11)
       at Compiler.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/CachePlugin.js:40:4)
       at Compiler.applyPluginsAsync (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:71:13)
       at Compiler.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compiler.js:400:9)
       at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compilation.js:577:13)
       at Compilation.applyPluginsAsync (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:60:69)
       at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compilation.js:572:10)
       at Compilation.next (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:67:11)
       at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/optimize/UglifyJsPlugin.js:140:4)
       at Compilation.applyPluginsAsync (/Users/tyler/elastic/kibana/node_modules/tapable/lib/Tapable.js:71:13)
       at Compilation.<anonymous> (/Users/tyler/elastic/kibana/node_modules/webpack/lib/Compilation.js:567:9)
     data: { errors: [Object], warnings: [], publicPath: '/bundles/' },
     isBoom: true,
     isServer: true,
     output: { statusCode: 500, payload: [Object], headers: {} },
     reformat: [Function] },
  isOperational: true,
  data:
   { errors:
      [ 'kibana.bundle.js from UglifyJs\nSyntaxError: Name expected [kibana.bundle.js:89156,5]',
        'timelion.bundle.js from UglifyJs\nSyntaxError: Name expected [timelion.bundle.js:88897,5]' ],
     warnings: [],
     publicPath: '/bundles/' },
  isBoom: true,
  isServer: true,
  output:
   { statusCode: 500,
     payload:
      { statusCode: 500,
        error: 'Internal Server Error',
        message: 'An internal server error occurred' },
     headers: {} },
  reformat: [Function] }

in these cases, named exports are the better replacement

don't export as default, rely on the named export

no reason not to, they pass when the no-var rule is disabled

tylersmalley · 2017-06-05T22:37:20Z

src/core_plugins/elasticsearch/lib/__tests__/create_proxy.js

@@ -1,5 +1,5 @@
 import expect from 'expect.js';
-import createProxy from '../create_proxy';
+import { createProxy } from '../create_proxy';


Should be importing createPath here and update the references for the tests to pass.

tylersmalley

LGTM - tested build against x-pack

w33ble added Team:Operations Team label for Operations Team chore dev WIP Work in progress labels May 30, 2017

w33ble mentioned this pull request May 30, 2017

Add eslint import resolution #12025

Merged

w33ble force-pushed the dev/replace-module-exports branch 2 times, most recently from af39b18 to 0b013c0 Compare May 31, 2017 01:44

spalger self-requested a review May 31, 2017 18:04

w33ble force-pushed the dev/replace-module-exports branch from 37f0990 to 88f9808 Compare May 31, 2017 18:52

w33ble requested review from tylersmalley and rhoboat May 31, 2017 20:12

w33ble added review and removed WIP Work in progress labels May 31, 2017

w33ble force-pushed the dev/replace-module-exports branch from 0612b12 to 69c84ce Compare May 31, 2017 21:57

spalger approved these changes Jun 1, 2017

View reviewed changes

w33ble force-pushed the dev/replace-module-exports branch 2 times, most recently from ae4bffd to 8be360e Compare June 2, 2017 19:15

w33ble added 12 commits June 5, 2017 15:05

use es6 exports in fixtures

3707e14

use es6 exports in test_utils

2cfd3cf

use es6 exports in src/ui

3709ee7

use es6 exports in src/utils

a241cfb

use es6 exports in src/server

7e7262a

use es6 exports in timelion

f558cd9

use es6 exports in core plugins, but not console

a79f62b

use es6 exports in console

a391e5a

use es6 exports in src/cli

fabc75f

use eslint --fix for no-extra-semi rule

525813f

selectively disable kibana-custom/no-default-export

1256299

replace define() with exports

8e634fe

w33ble and others added 11 commits June 5, 2017 15:08

clean up some object exports

ad9ddef

in these cases, named exports are the better replacement

use es6 exports in src/optimize, where possible

a1c18bd

fix uses of named exports

958c648

fix some imports in console

fd29fbc

revert postcss optimizer to module.exports

0d7b9d5

[timelion] put shared code in common directory

5aadca3

fix url module export

952402a

don't export as default, rely on the named export

convert define modules in src to export

80722e1

convert ui-bootstrap to cjs module

126deb3

lint webpackShims

53172cd

no reason not to, they pass when the no-var rule is disabled

fix new code not using es6 exports

823f984

w33ble force-pushed the dev/replace-module-exports branch from d73580f to f131c59 Compare June 5, 2017 22:10

w33ble added the v6.0.0-alpha3 label Jun 5, 2017

tylersmalley reviewed Jun 5, 2017

View reviewed changes

fix some straggling exports

729a456

w33ble force-pushed the dev/replace-module-exports branch from f131c59 to 729a456 Compare June 5, 2017 22:49

tylersmalley approved these changes Jun 6, 2017

View reviewed changes

w33ble merged commit 262bcb4 into elastic:master Jun 6, 2017

simianhacker mentioned this pull request Jun 6, 2017

Fixes for Dashboard Context for both TSVB and Timelion #12214

Merged

epixa added v6.0.0-beta1 and removed v6.0.0-beta1 v6.0.0-alpha3 labels Jul 10, 2017

jimgoodwin added the release_note:fix label Jul 25, 2017

romaindequidt mentioned this pull request Nov 3, 2017

WIP: Upgrade up to Kibana version 5.6.3 bitsensor/elastalert-kibana-plugin#23

Merged

elasticmachine mentioned this pull request Apr 24, 2018

Cleanup: remove all the module.exports #18003

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use es6 exports, replace module.exports #12084

Use es6 exports, replace module.exports #12084

w33ble commented May 30, 2017 •

edited

Loading

spalger left a comment

tylersmalley commented Jun 2, 2017

tylersmalley Jun 5, 2017

tylersmalley left a comment

Use es6 exports, replace module.exports #12084

Use es6 exports, replace module.exports #12084

Conversation

w33ble commented May 30, 2017 • edited Loading

spalger left a comment

Choose a reason for hiding this comment

tylersmalley commented Jun 2, 2017

tylersmalley Jun 5, 2017

Choose a reason for hiding this comment

tylersmalley left a comment

Choose a reason for hiding this comment

w33ble commented May 30, 2017 •

edited

Loading