[Security Solution] Fixes the position of popover when presenting dynamic content #139079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
changed the title
logeekal
added
backport:prev-minor
logeekal
added
the
release_note:skip
janmonschke
approved these changes
Aug 18, 2022
That is a good point @janmonschke. I will followup with QA team on the same. |
|
|
@stephmilovic I 100% agree. But I noticed this on https://kibana.siem.estc.dev/ as well and this seems to be a consistent behaviour so I assumed this is not broken and did not touch it. But if we agree that |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
stephmilovic
approved these changes
Aug 24, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 25, 2022
…amic content (elastic#139079) ## Summary Issue elastic#133186 ( as shown in below video) demonstrates couple of issues and this PR tries to fix those. https://user-images.githubusercontent.com/61860752/171141631-f633a223-af76-457d-bed2-6bd8ea418a0e.mp4 **ISSUE - 1** When in host details flyout, clicking on `show Top N`, the datagrid will flicker scrolling from right to left and then back to its original position. **Solution** : This issue was not reproducible so I am assuming this has been already resolved. ( See below video for more details) **ISSUE - 2** When in host details flyout, clicking on `show Top N`, the popup hides behind the bottom screen edge. This is because initially the popup was small but when `Show TopN` is clicked, the content of Popup is changed and popup becomes bigger in size forcing it to exceed out of the screen's real estate. **Solution** : This PR makes sure that, if hover actions Popup's content changes, Popup is re-positioned according to its new dimensions. Checkout below demonstration. https://user-images.githubusercontent.com/7485038/185380538-d8fb159a-d666-4be2-b3b0-161a21d1b9d6.mov (cherry picked from commit acf675c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 25, 2022
…amic content (#139079) (#139454) ## Summary Issue #133186 ( as shown in below video) demonstrates couple of issues and this PR tries to fix those. https://user-images.githubusercontent.com/61860752/171141631-f633a223-af76-457d-bed2-6bd8ea418a0e.mp4 **ISSUE - 1** When in host details flyout, clicking on `show Top N`, the datagrid will flicker scrolling from right to left and then back to its original position. **Solution** : This issue was not reproducible so I am assuming this has been already resolved. ( See below video for more details) **ISSUE - 2** When in host details flyout, clicking on `show Top N`, the popup hides behind the bottom screen edge. This is because initially the popup was small but when `Show TopN` is clicked, the content of Popup is changed and popup becomes bigger in size forcing it to exceed out of the screen's real estate. **Solution** : This PR makes sure that, if hover actions Popup's content changes, Popup is re-positioned according to its new dimensions. Checkout below demonstration. https://user-images.githubusercontent.com/7485038/185380538-d8fb159a-d666-4be2-b3b0-161a21d1b9d6.mov (cherry picked from commit acf675c) Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
…amic content (elastic#139079) ## Summary Issue elastic#133186 ( as shown in below video) demonstrates couple of issues and this PR tries to fix those. https://user-images.githubusercontent.com/61860752/171141631-f633a223-af76-457d-bed2-6bd8ea418a0e.mp4 **ISSUE - 1** When in host details flyout, clicking on `show Top N`, the datagrid will flicker scrolling from right to left and then back to its original position. **Solution** : This issue was not reproducible so I am assuming this has been already resolved. ( See below video for more details) **ISSUE - 2** When in host details flyout, clicking on `show Top N`, the popup hides behind the bottom screen edge. This is because initially the popup was small but when `Show TopN` is clicked, the content of Popup is changed and popup becomes bigger in size forcing it to exceed out of the screen's real estate. **Solution** : This PR makes sure that, if hover actions Popup's content changes, Popup is re-positioned according to its new dimensions. Checkout below demonstration. https://user-images.githubusercontent.com/7485038/185380538-d8fb159a-d666-4be2-b3b0-161a21d1b9d6.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #133186 ( as shown in below video) demonstrates couple of issues and this PR tries to fix those.
show.top.mp4
ISSUE - 1
When in host details flyout, clicking on
show Top N, the datagrid will flicker scrolling from right to left and then back to its original position.Solution : This issue was not reproducible so I am assuming this has been already resolved. ( See below video for more details)
ISSUE - 2
When in host details flyout, clicking on
show Top N, the popup hides behind the bottom screen edge. This is because initially the popup was small but whenShow TopNis clicked, the content of Popup is changed and popup becomes bigger in size forcing it to exceed out of the screen's real estate.Solution : This PR makes sure that, if hover actions Popup's content changes, Popup is re-positioned according to its new dimensions. Checkout below demonstration.
Screen.Recording.2022-08-18.at.13.02.40.mov
For maintainers