-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated layout to incease the field width #141084
fix: updated layout to incease the field width #141084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Fixes: elastic#126083 Changed the layout of the Add Field popover so that field `Field` can have full width and users can see long index properties without any issue. Please see if new layout makes sense. This solves the width problem without any customization. |Old Layout| New Layout| |--|--| |![image](https://user-images.githubusercontent.com/7485038/191256799-b38b4e23-6bb0-492d-8908-bf63eeb7994c.png)|![image](https://user-images.githubusercontent.com/7485038/191256474-77263af3-e593-46a9-a31e-be54a9518f45.png)| (cherry picked from commit 2b4fc2e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Fixes: #126083 Changed the layout of the Add Field popover so that field `Field` can have full width and users can see long index properties without any issue. Please see if new layout makes sense. This solves the width problem without any customization. |Old Layout| New Layout| |--|--| |![image](https://user-images.githubusercontent.com/7485038/191256799-b38b4e23-6bb0-492d-8908-bf63eeb7994c.png)|![image](https://user-images.githubusercontent.com/7485038/191256474-77263af3-e593-46a9-a31e-be54a9518f45.png)| (cherry picked from commit 2b4fc2e) Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
Summary
Fixes: #126083
Changed the layout of the Add Field popover so that field
Field
can have full width and users can see long index properties without any issue.Please see if new layout makes sense. This solves the width problem without any customization.
Checklist
Delete any items that are not applicable to this PR.
For maintainers