[Dashboard] [Controls] Skip First Reload

[ThomThomson]

Summary

Fixes an issue where Discover Saved Searches sometimes were aborted on the first load of a dashboard.

This was caused by the control group forcing a lastReloadRequestTime updated on dashboards on their first load, even though the control group selections which were saved into the dashboard had already been applied.

This PR fixes this by postponing the dashboard control group sync code until after the control group is finished loading and outputting its initial filters, and by skipping the first, blank filter update that the control group outputs.

How to test

Because the discover issue is difficult to reproduce with the demo data, and locally, the best way to test this would be to place a console log in
src/plugins/dashboard/public/application/lib/dashboard_control_group.ts line 146. and ensure that the dashboard container's lastReloadRequestTime is only updated when expected.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: a4e5a16

Failed CI Steps

• FTR Configs #19

Test Failures

• [job] [logs] FTR Configs #19 / dashboard drilldowns Dashboard to dashboard drilldown Create & use drilldowns test dashboard to dashboard drilldown with controls use dashboard to dashboard drilldown via onClick action

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dashboard	419.4KB	419.5KB	+129.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[Heenawter]

Code review + tested locally by putting the console.log in the place described and doing the following:

1. Loaded a dashboard with controls with no selections - lastReloadRequestTime was not updated by the control group
2. Made a selection for one of the controls - lastReloadRequestTime was* updated
3. Saved the dashboard after making selection and refreshed the dashboard - lastReloadRequestTime was not updated and the filters from the previous selections were applied as expected
4. Made another selection, leaving the dashboard in an unsaved state, and refreshed the dashboard - lastReloadRequestTime was not updated and the filters from the unsaved selections were applied as expected

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.