[Controls] Fix Initialization Race Condition #143220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomThomson
added
Feature:Dashboard
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Heenawter
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Code review + tested locally:
- Throttled the network connection and ensured that the control group fully loaded before the dashboard container did
- Console logged once the control group children were all marked as ready, the control group was initialized, and the dashboard container was done loading - ensured that these logs followed the expected order under various conditions.
- Followed a dashboard-to-dashboard drilldown with control selections and everything worked as expected.
Everything worked great 👍 What a nasty bug!
ThomThomson
added
the
backport:prev-minor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Oct 12, 2022
* Fix Initialization Race Condition (cherry picked from commit 702827b) # Conflicts: # src/plugins/dashboard/public/application/embeddable/dashboard_container_factory.tsx # x-pack/test/functional/apps/dashboard/group3/drilldowns/dashboard_to_dashboard_drilldown.ts
ThomThomson
added a commit
that referenced
this pull request
Oct 12, 2022
* Fix Initialization Race Condition (cherry picked from commit 702827b) # Conflicts: # src/plugins/dashboard/public/application/embeddable/dashboard_container_factory.tsx # x-pack/test/functional/apps/dashboard/group3/drilldowns/dashboard_to_dashboard_drilldown.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition introduced in #142868 by forcing the dashboard container to initialize after the control group is finished loading.
Previously, the dashboard viewport and the container would wait until all of the Control children had finished loading before rendering, but they would not wait for the control group to finish loading before starting to initialize embeddable children.
This could cause a race condition in cases when the Dashboard's panels loaded too quickly to get the initial filters from the control group.
Fixes #142912
Fixes #142913
Flaky test runner