Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.5] [Controls] Fix Initialization Race Condition (#143220) #143246

Merged
merged 1 commit into from
Oct 12, 2022
Merged

[8.5] [Controls] Fix Initialization Race Condition (#143220) #143246

merged 1 commit into from
Oct 12, 2022

Conversation

ThomThomson
Copy link
Contributor

Backport

This will backport the following commits from main to 8.5:

Questions ?

Please refer to the Backport tool documentation

@ThomThomson
[Controls] Fix Initialization Race Condition (elastic#143220)
d606b83 
* Fix Initialization Race Condition

(cherry picked from commit 702827b)

# Conflicts:
#	src/plugins/dashboard/public/application/embeddable/dashboard_container_factory.tsx
#	x-pack/test/functional/apps/dashboard/group3/drilldowns/dashboard_to_dashboard_drilldown.ts
@ThomThomson ThomThomson requested a review from a team as a code owner October 12, 2022 22:27
@ThomThomson ThomThomson enabled auto-merge (squash) October 12, 2022 22:27
@ThomThomson ThomThomson mentioned this pull request Oct 12, 2022
Merged
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
controls 204 205 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 458.6KB 458.9KB +313.0B
dashboard 388.5KB 388.2KB -332.0B
total -19.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 72.2KB 72.4KB +212.0B
Unknown metric groups

API count

id before after diff
controls 212 213 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit f70e869 into elastic:8.5 Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomThomson @kibana-ci