[Stack Monitoring] api tests for logstash #145351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klacabane
added
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @klacabane |
kibanamachine
added
v8.7.0
backport:skip
crespocarlos
added a commit
that referenced
this pull request
Feb 7, 2023
## Summary closes #142642 This PR fixes the expected result for the node_detail_mb test. One of the possible reasons why it failed is because this [PR changed the cpu load_average fields type to `half_float`](elastic/beats@7ba1426), making the `logstash_os_load` metrics to be different from the expected results. This problem doesn't happen in 8.7, because, [among other things, this PR updated the expected result, with the correct values](#145351) ### How to test ```bash node scripts/functional_test_runner --config x-pack/test/api_integration/config.ts --include x-pack/test/api_integration/apis/monitoring/logstash/node_detail_mb.js ``` Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #119658
Add api integration tests for logstash routes to validate behavior when reading data ingested by elastic-agent.
We currently have a testing suite for legacy and another one for metricbeat. Since metricbeat and agent documents only differ in their metadata, for example agent will populate a
data_stream.*property to identify the document types while metricbeat usesmetricset.*, the tests assertion validating business data should pass regardless of the documents source. With this in mind the metricbeat tests were updated to run the tests twice, one time with metricbeat data and a second time with package data.To generate the archives the
metrics-*mappings were extracted with esArchiver from an elasticsearch with the package installed, and the documents were transformed from the metricbeat documents with this script.