Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guided onboarding] Copy update for the Security rules step #145887

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Nov 21, 2022

Summary

This PR adds a sentence to the Rules step in the Security guide.

Screenshot 2022-11-21 at 17 04 01

cc @paulewing

@yuliacech yuliacech added release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.6.0 v8.7.0 labels Nov 21, 2022
@yuliacech yuliacech marked this pull request as ready for review November 21, 2022 16:05
@yuliacech yuliacech requested a review from a team as a code owner November 21, 2022 16:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
guidedOnboarding 28.1KB 28.2KB +126.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy change LGTM.

@yuliacech yuliacech merged commit f1cdc08 into elastic:main Nov 23, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 23, 2022
…145887)

## Summary
This PR adds a sentence to the Rules step in the Security guide.

<img width="458" alt="Screenshot 2022-11-21 at 17 04 01"
src="https://user-images.githubusercontent.com/6585477/203102051-d3fe053b-4cf1-499d-937d-64acda7c7c41.png">

cc @paulewing

(cherry picked from commit f1cdc08)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@yuliacech
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

yuliacech added a commit to yuliacech/kibana that referenced this pull request Nov 23, 2022
…145887)

## Summary
This PR adds a sentence to the Rules step in the Security guide.

<img width="458" alt="Screenshot 2022-11-21 at 17 04 01"
src="https://user-images.githubusercontent.com/6585477/203102051-d3fe053b-4cf1-499d-937d-64acda7c7c41.png">

cc @paulewing

(cherry picked from commit f1cdc08)
kibanamachine added a commit that referenced this pull request Nov 23, 2022
…45887) (#146102)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Guided onboarding] Copy update for the Security rules step
(#145887)](#145887)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yulia
Čech","email":"6585477+yuliacech@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-23T09:04:45Z","message":"[Guided
onboarding] Copy update for the Security rules step (#145887)\n\n##
Summary\r\nThis PR adds a sentence to the Rules step in the Security
guide. \r\n\r\n<img width=\"458\" alt=\"Screenshot 2022-11-21 at 17 04
01\"\r\nsrc=\"https://user-images.githubusercontent.com/6585477/203102051-d3fe053b-4cf1-499d-937d-64acda7c7c41.png\">\r\n\r\ncc
@paulewing","sha":"f1cdc08253fbb3ebc4c21e5a5fd21862aa5a4e42","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Journey/Onboarding","v8.6.0","v8.7.0"],"number":145887,"url":"https://github.com/elastic/kibana/pull/145887","mergeCommit":{"message":"[Guided
onboarding] Copy update for the Security rules step (#145887)\n\n##
Summary\r\nThis PR adds a sentence to the Rules step in the Security
guide. \r\n\r\n<img width=\"458\" alt=\"Screenshot 2022-11-21 at 17 04
01\"\r\nsrc=\"https://user-images.githubusercontent.com/6585477/203102051-d3fe053b-4cf1-499d-937d-64acda7c7c41.png\">\r\n\r\ncc
@paulewing","sha":"f1cdc08253fbb3ebc4c21e5a5fd21862aa5a4e42"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145887","number":145887,"mergeCommit":{"message":"[Guided
onboarding] Copy update for the Security rules step (#145887)\n\n##
Summary\r\nThis PR adds a sentence to the Rules step in the Security
guide. \r\n\r\n<img width=\"458\" alt=\"Screenshot 2022-11-21 at 17 04
01\"\r\nsrc=\"https://user-images.githubusercontent.com/6585477/203102051-d3fe053b-4cf1-499d-937d-64acda7c7c41.png\">\r\n\r\ncc
@paulewing","sha":"f1cdc08253fbb3ebc4c21e5a5fd21862aa5a4e42"}}]}]
BACKPORT-->

Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
yuliacech added a commit that referenced this pull request Nov 23, 2022
…45887) (#146103)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Guided onboarding] Copy update for the Security rules step
(#145887)](#145887)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yulia
Čech","email":"6585477+yuliacech@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-23T09:04:45Z","message":"[Guided
onboarding] Copy update for the Security rules step (#145887)\n\n##
Summary\r\nThis PR adds a sentence to the Rules step in the Security
guide. \r\n\r\n<img width=\"458\" alt=\"Screenshot 2022-11-21 at 17 04
01\"\r\nsrc=\"https://user-images.githubusercontent.com/6585477/203102051-d3fe053b-4cf1-499d-937d-64acda7c7c41.png\">\r\n\r\ncc
@paulewing","sha":"f1cdc08253fbb3ebc4c21e5a5fd21862aa5a4e42","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Journey/Onboarding","v8.6.0","v8.7.0"],"number":145887,"url":"https://github.com/elastic/kibana/pull/145887","mergeCommit":{"message":"[Guided
onboarding] Copy update for the Security rules step (#145887)\n\n##
Summary\r\nThis PR adds a sentence to the Rules step in the Security
guide. \r\n\r\n<img width=\"458\" alt=\"Screenshot 2022-11-21 at 17 04
01\"\r\nsrc=\"https://user-images.githubusercontent.com/6585477/203102051-d3fe053b-4cf1-499d-937d-64acda7c7c41.png\">\r\n\r\ncc
@paulewing","sha":"f1cdc08253fbb3ebc4c21e5a5fd21862aa5a4e42"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/146102","number":146102,"state":"OPEN"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145887","number":145887,"mergeCommit":{"message":"[Guided
onboarding] Copy update for the Security rules step (#145887)\n\n##
Summary\r\nThis PR adds a sentence to the Rules step in the Security
guide. \r\n\r\n<img width=\"458\" alt=\"Screenshot 2022-11-21 at 17 04
01\"\r\nsrc=\"https://user-images.githubusercontent.com/6585477/203102051-d3fe053b-4cf1-499d-937d-64acda7c7c41.png\">\r\n\r\ncc
@paulewing","sha":"f1cdc08253fbb3ebc4c21e5a5fd21862aa5a4e42"}}]}]
BACKPORT-->
@yuliacech yuliacech deleted the guided_onboarding/8.6_rules_copy branch February 6, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.6.0 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants