Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] [Controls] Unskip options list failed tests #151770

Merged
merged 1 commit into from
Feb 21, 2023
Merged

[Dashboard] [Controls] Unskip options list failed tests #151770

merged 1 commit into from
Feb 21, 2023

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Feb 21, 2023 •
edited
Loading

Closes #141285

Summary

Unskips the failed options_list_creation_and_editing.ts tests since the underlying bug is no longer present as of v8.5.0.

Flaky Test Runner

Checklist

For maintainers

@Heenawter Heenawter added Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. backport:skip This commit does not require backporting labels Feb 21, 2023
@Heenawter Heenawter force-pushed the unskip-controls-flaky-test_2023-02-21 branch 2 times, most recently from afb23dc to 480a3d2 Compare February 21, 2023 18:49
@Heenawter Heenawter force-pushed the unskip-controls-flaky-test_2023-02-21 branch from 480a3d2 to caefb70 Compare February 21, 2023 18:51
@Heenawter Heenawter changed the title [Dashboard] [Controls] Unskip options list flaky tests [Dashboard] [Controls] Unskip options list failed tests Feb 21, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #109390 failed afb23dcb4ad53a4aea4efb84e213f3a4ce4d8de6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Heenawter Heenawter marked this pull request as ready for review February 21, 2023 20:12
@Heenawter Heenawter requested a review from a team as a code owner February 21, 2023 20:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

nreese
nreese approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review. Thanks for confirming this is no longer broken on cloud

@Heenawter Heenawter merged commit f51ea03 into elastic:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Input Control Input controls visualization impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.8.0
Projects
None yet
Milestone
No milestone
5 participants
@Heenawter @kibana-ci @elasticmachine @nreese @kibanamachine