[Security Solution] Re-enable a skipped url state e2e test #152075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpn
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @maximpn |
kqualters-elastic
approved these changes
Feb 28, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 1, 2023
…52075) **Relates to:** elastic#151244 ## Summary Re-enable `Do not clears kql when navigating to a new page` url state e2e test. ## Details Investigation has shown that elastic#150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next `kqlSearch()` command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removed `kqlSearch()` command and fixed the test this way. (cherry picked from commit 5514f93)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
2 tasks
kibanamachine
added a commit
that referenced
this pull request
Mar 1, 2023
…2075) (#152423) # Backport This will backport the following commits from `main` to `8.7`: - [[Security Solution] Re-enable a skipped url state e2e test (#152075)](#152075) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2023-03-01T09:04:31Z","message":"[Security Solution] Re-enable a skipped url state e2e test (#152075)\n\n**Relates to:** https://github.com/elastic/kibana/pull/151244\r\n\r\n## Summary\r\n\r\nRe-enable `Do not clears kql when navigating to a new page` url state e2e test.\r\n\r\n## Details\r\n\r\nInvestigation has shown that #150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next `kqlSearch()` command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removed `kqlSearch()` command and fixed the test this way.","sha":"5514f93fc8ecccc007d1e25c9413df1c739feae9","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rules","backport:prev-minor","v8.7.0","v8.8.0"],"number":152075,"url":"https://github.com/elastic/kibana/pull/152075","mergeCommit":{"message":"[Security Solution] Re-enable a skipped url state e2e test (#152075)\n\n**Relates to:** https://github.com/elastic/kibana/pull/151244\r\n\r\n## Summary\r\n\r\nRe-enable `Do not clears kql when navigating to a new page` url state e2e test.\r\n\r\n## Details\r\n\r\nInvestigation has shown that #150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next `kqlSearch()` command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removed `kqlSearch()` command and fixed the test this way.","sha":"5514f93fc8ecccc007d1e25c9413df1c739feae9"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152075","number":152075,"mergeCommit":{"message":"[Security Solution] Re-enable a skipped url state e2e test (#152075)\n\n**Relates to:** https://github.com/elastic/kibana/pull/151244\r\n\r\n## Summary\r\n\r\nRe-enable `Do not clears kql when navigating to a new page` url state e2e test.\r\n\r\n## Details\r\n\r\nInvestigation has shown that #150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next `kqlSearch()` command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removed `kqlSearch()` command and fixed the test this way.","sha":"5514f93fc8ecccc007d1e25c9413df1c739feae9"}}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…52075) **Relates to:** elastic#151244 ## Summary Re-enable `Do not clears kql when navigating to a new page` url state e2e test. ## Details Investigation has shown that elastic#150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next `kqlSearch()` command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removed `kqlSearch()` command and fixed the test this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #151244
Summary
Re-enable
Do not clears kql when navigating to a new pageurl state e2e test.Details
Investigation has shown that #150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next
kqlSearch()command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removedkqlSearch()command and fixed the test this way.