[Cases] Adding files configuration fields #154013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
Team:ResponseOps
13 tasks
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
reviewed
Apr 3, 2023
| describe('no mime types', () => { | ||
| const schema = ConfigSchema.validate({ files: { allowedMimeTypes: [] } }); | ||
|
|
||
| it('sets the cases file kind allowed mime types to only image png', () => { |
There was a problem hiding this comment.
nit: sets the cases file kind allowed to no mime types
5 tasks
|
@jonathan-buttner How do I attach a file to a case? 😅 I can't seem to find the control |
💚 Build Succeeded
Metrics [docs]Module Count
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jonathan-buttner
added a commit
that referenced
this pull request
Apr 12, 2023
This PR adds the new configuration settings to the docs. The configurations were added in this PR: #154013 --------- Co-authored-by: lcawl <lcawley@elastic.co>
jonathan-buttner
added a commit
that referenced
this pull request
Apr 19, 2023
This PR adds the follow cases config options from this PR to the docker script. #154013 ``` xpack.cases.files.allowedMimeTypes xpack.cases.files.maxSize ```
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #151935
This PR allows the mime types and max file size for the files functionality within cases to be configured through the kibana.yml. We set the defaults maxSize to be 100 mb and if it is not set by the user we also restrict images to be 10 mb. If the
maxSizeis set by the user we use it for all mime types including images (or whatever the user has specified inallowedMimeTypes).The file service changes are just mocks to help with testing some of the configuration options.
New fields
Release Notes
Cases added two configuration options to allow users to control which files mime types are allowed to be attached to cases and the approved max size of a file being upload.
xpack.cases.files.allowedMimeTypes- An array of strings representing the allowed mime types to be attached to a case.xpack.cases.files.maxSize- A number representing the file size limit for files being attached to a case (in bytes).