[Cases] Limit category filter in find cases API #159989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:skip
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
adcoelho
force-pushed
the
limit-rows-find-category-api
branch
from
9c08624 to
532f240
Compare
jonathan-buttner
approved these changes
Jun 20, 2023
| @@ -103,5 +104,15 @@ describe('find', () => { | |||
| 'Error: Invalid value "foobar" supplied to "searchFields"' | |||
| ); | |||
| }); | |||
|
|
|||
| it(`invalid category array with > ${MAX_CATEGORY_FILTER_LENGTH} items`, async () => { | |||
There was a problem hiding this comment.
nit: it(throws an error when the category array has...)
| @@ -349,6 +349,12 @@ export default ({ getService }: FtrProviderContext): void => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('unhappy path - 400s when bad category field supplied', async () => { | |||
There was a problem hiding this comment.
nit: it('... 400s when more than the maximum category fields are supplied')
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @adcoelho |
adcoelho
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR limits the number of categories by which we can filter calls to the find cases API.
The limit is now 100.