-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Include synthetics-* for existing alerts #160063
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/uptime (Team:uptime) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit a2cc9a6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…61334) # Backport This will backport the following commits from `main` to `8.9`: - [[Uptime] Include synthetics-* for existing alerts (#160063)](#160063) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-07-06T10:26:22Z","message":"[Uptime] Include synthetics-* for existing alerts (#160063)","sha":"a2cc9a69241726a4498717f391ad18e35d38e7dc","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.9.0","v8.10.0"],"number":160063,"url":"https://github.com/elastic/kibana/pull/160063","mergeCommit":{"message":"[Uptime] Include synthetics-* for existing alerts (#160063)","sha":"a2cc9a69241726a4498717f391ad18e35d38e7dc"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160063","number":160063,"mergeCommit":{"message":"[Uptime] Include synthetics-* for existing alerts (#160063)","sha":"a2cc9a69241726a4498717f391ad18e35d38e7dc"}}]}] BACKPORT-->
Summary
Include synthetics-* for existing alerts !!
We need to continue adding synthetics-* in case synthetics-* was removed from settings in migration for alerts.