Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Include synthetics-* for existing alerts #160063

Merged
merged 7 commits into from
Jul 6, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jun 20, 2023

Summary

Include synthetics-* for existing alerts !!

We need to continue adding synthetics-* in case synthetics-* was removed from settings in migration for alerts.

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels Jun 20, 2023
@shahzad31 shahzad31 marked this pull request as ready for review June 20, 2023 16:53
@shahzad31 shahzad31 requested a review from a team as a code owner June 20, 2023 16:53
@paulb-elastic paulb-elastic added the bug Fixes for quality problems that affect the customer experience label Jun 27, 2023
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit a2cc9a6 into elastic:main Jul 6, 2023
@shahzad31 shahzad31 deleted the uptime-alerts branch July 6, 2023 10:26
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.9 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 160063

Questions ?

Please refer to the Backport tool documentation

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jul 6, 2023
@shahzad31
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

shahzad31 added a commit that referenced this pull request Jul 6, 2023
…61334)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Uptime] Include synthetics-* for existing alerts
(#160063)](#160063)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-07-06T10:26:22Z","message":"[Uptime]
Include synthetics-* for existing alerts
(#160063)","sha":"a2cc9a69241726a4498717f391ad18e35d38e7dc","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.9.0","v8.10.0"],"number":160063,"url":"https://github.com/elastic/kibana/pull/160063","mergeCommit":{"message":"[Uptime]
Include synthetics-* for existing alerts
(#160063)","sha":"a2cc9a69241726a4498717f391ad18e35d38e7dc"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160063","number":160063,"mergeCommit":{"message":"[Uptime]
Include synthetics-* for existing alerts
(#160063)","sha":"a2cc9a69241726a4498717f391ad18e35d38e7dc"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants