Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Guardrails: Limit bulk get cases and bulk get attachments #161088

Merged

Conversation

adcoelho
Copy link
Contributor

@adcoelho adcoelho commented Jul 3, 2023

Connected to #146945

Summary

Description Limit Done? Documented?
Total number of attachments returned by bulk get API 100 No (internal)
Total number of cases returned by bulk get API 1000 No (internal)
  • Replaced the code validation with schema validation.
  • BulkGet Cases
    • The minimum of cases that can be returned is now 1(was not validated before).
  • BulkGet Attachments
    • The maximum of attachments that can be returned is now 100(was 10000).
    • The minimum of attachments that can be returned is now 1(was not validated before).
  • Updated unit and e2e tests.
  • The documentation was not updated because these are internal APIs.
  • Skipping the release notes because these are internal APIs.

Checklist

Delete any items that are not applicable to this PR.

@adcoelho adcoelho added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.10.0 labels Jul 3, 2023
@adcoelho adcoelho self-assigned this Jul 3, 2023
@adcoelho adcoelho marked this pull request as ready for review July 3, 2023 12:06
@adcoelho adcoelho requested a review from a team as a code owner July 3, 2023 12:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 documentation is missing 😄

@adcoelho
Copy link
Contributor Author

adcoelho commented Jul 3, 2023

@js-jankisalvi internal apis dont need it ;D

@js-jankisalvi
Copy link
Contributor

@js-jankisalvi internal apis dont need it ;D

Ahh great!! didn't know that 😄 Thanks

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #6 / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when adding a filter

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 144.5KB 144.6KB +152.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@adcoelho adcoelho merged commit 41fec24 into elastic:main Jul 4, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants