[Cases] limit number of attachments that can be created using the bulk create API #161451
Conversation
js-jankisalvi
added
release_note:breaking
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
…-ref HEAD~1..HEAD --fix'
cnasikas
added
release_note:skip
| owner: 'securitySolutionFixture', | ||
| }; | ||
|
|
||
| const attachments = Array(101).fill(comment); |
There was a problem hiding this comment.
In these integration tests I never know if I wanna just put the value or import the constant(MAX_BULK_CREATE_ATTACHMENTS)
There was a problem hiding this comment.
yeah, but I thought it's good that integration tests fail when constant is changed, reminds us what all places we have put this check 😄
There was a problem hiding this comment.
😆 I tend to user the value for the reasons Janki mentioned.
| comment: 'Solve this fast!', | ||
| type: CommentType.user, | ||
| owner: 'cases', | ||
| foo: 'bar', |
There was a problem hiding this comment.
Could you remove the foo: 'bar' field that is related to a different error? (I did the same mistake 😄 )
…s-jankisalvi/kibana into total-attachements-bulk-create
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Connected to #146945
Summary
Checklist
Delete any items that are not applicable to this PR.