Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Remove an unused function for "extension" files #161871

Merged

Conversation

yuliacech
Copy link
Contributor

Summary

Related to #159041

While working on #161684, I noticed another unused function. There is no usage in the code base of the "extensions" function and I think it would be better to delete it from Console. That makes the remaining code that we need to work with easier to understand.

Release note

The function addExtensionSpecFilePath is removed from the Console plugin setup contract (server side).

@yuliacech yuliacech added release_note:breaking Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.10.0 labels Jul 13, 2023
@yuliacech yuliacech requested a review from a team as a code owner July 13, 2023 14:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 490 494 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ElenaStoeva ElenaStoeva self-requested a review July 13, 2023 15:26
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for removing this redundancy @yuliacech. LGTM

@yuliacech yuliacech merged commit c36b620 into elastic:main Jul 13, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 13, 2023
@yuliacech yuliacech deleted the console/remove_extentsions_function branch February 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature release_note:breaking Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants