[Cases] Total external references and persistable state attachments per case #162071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:breaking
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
reviewed
Jul 24, 2023
...lugins/cases/server/common/limiter_checker/limiters/persistableStateAndExternalReferences.ts
Outdated
Show resolved
Hide resolved
...s/cases/server/common/limiter_checker/limiters/persistableStateAndExternalReferences.test.ts
Outdated
Show resolved
Hide resolved
...s/cases/server/common/limiter_checker/limiters/persistableStateAndExternalReferences.test.ts
Outdated
Show resolved
Hide resolved
...s/cases/server/common/limiter_checker/limiters/persistableStateAndExternalReferences.test.ts
Outdated
Show resolved
Hide resolved
...s/cases/server/common/limiter_checker/limiters/persistableStateAndExternalReferences.test.ts
Outdated
Show resolved
Hide resolved
| createAlertRequests, | ||
| createExternalReferenceRequests, | ||
| createPersistableStateRequests, | ||
| createUserRequests, |
There was a problem hiding this comment.
nit: There are the same mocks in x-pack/plugins/cases/server/mocks.ts or x-pack/test/cases_api_integration/common/lib/mock.ts. Otherwise, we can extract these mock functions to x-pack/plugins/cases/server/mocks.ts.
|
Added integration tests for the internal |
js-jankisalvi
approved these changes
Jul 24, 2023
cnasikas
reviewed
Jul 25, 2023
| service.countPersistableStateAndExternalReferenceAttachments({ caseId: 'test-id' }) | ||
| ).resolves.not.toThrow(); | ||
|
|
||
| await expect(unsecuredSavedObjectsClient.find).toHaveBeenCalledWith( |
There was a problem hiding this comment.
I do not think we need the await here.
cnasikas
reviewed
Jul 25, 2023
| ).resolves.not.toThrow(); | ||
|
|
||
| await expect(unsecuredSavedObjectsClient.find).toHaveBeenCalledWith( | ||
| expect.objectContaining({ |
There was a problem hiding this comment.
I think we should validate the filter passed to unsecuredSavedObjectsClient.find. You can do
expect(unsecuredSavedObjectsClient.find.mock.calls[0][0]).toMatchInlineSnapshot(...)
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @adcoelho |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…er case (elastic#162071) Connected to elastic#146945 ## Summary | Description | Limit | Done? | Documented? | ------------- | ---- | :---: | ---- | | Total number of attachments (external references and persistable state) per case | 100 | ✅ | No | ### Checklist Delete any items that are not applicable to this PR. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Release Notes A case can now only have 100 external references and persistable state(excluding files) attachments combined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #146945
Summary
Checklist
Delete any items that are not applicable to this PR.
Release Notes
A case can now only have 100 external references and persistable state(excluding files) attachments combined.