[Cases] UI validation for assignees, tags and categories filters #162411

js-jankisalvi · 2023-07-24T14:06:05Z

Summary

Connected to #146945

This PR adds UI validations for assignees, tags and categories filter on cases list table and cases selector modal:

Description	Limit	Done?	Documented?	UI?
Maximum number of assignees to filter	100	✅	Yes	✅
Maximum number of tags to filter	100	✅	Yes	✅
Maximum number of categories to filter	100	✅	Yes	✅

Selector modal:

Case list table:

Note: screenshots are taken with 5 as maximum limit for assignees, tags and categories filter:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)

For maintainers

This was checked for breaking API changes and was labeled appropriately

Release notes

The Find Cases API now limits

Maximum number of assignees to filter to 100
Maximum number of tags to filter to 100
Maximum number of categories to filter to 100

…ilters

elasticmachine · 2023-07-24T14:06:11Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2023-07-24T14:06:12Z

Pinging @elastic/response-ops-cases (Feature:Cases)

cnasikas

Creat job 🚀!!

x-pack/plugins/cases/public/components/all_cases/table_filters.tsx

x-pack/plugins/cases/public/components/all_cases/translations.ts

x-pack/plugins/cases/public/components/filter_popover/index.test.tsx

x-pack/plugins/cases/public/components/filter_popover/index.tsx

adcoelho · 2023-07-25T09:35:59Z

x-pack/plugins/cases/public/components/all_cases/assignees_filter.test.tsx

+    appMockRender.render(<AssigneesFilterPopover {...props} />);
+
+    await waitFor(async () => {
+      userEvent.click(screen.getByTestId('options-filter-popover-button-assignees'));


nit: we use the old "@testing-library/user-event": "^13.5.0", which doesn't return a promise(I think it is here) so this could be moved outside.

I tried to move userEvent.click(screen.getByTestId('options-filter-popover-button-assignees')); out of waitFor but test fails due to it.

Weird, in the documentation for this version they don't use it. I don't know what to believe anymore 😆

yeah, we also don't put it in waitFor in other components tests. Maybe something wrong in rendering this component.

FWIW, we can convert it to userEvent.click(await screen.findByTestId('options-filter-popover-button-assignees')); and remove the waitFor. All flavors of find* await for the element to appear.

x-pack/plugins/cases/public/components/filter_popover/index.tsx

x-pack/plugins/cases/public/components/all_cases/assignees_filter.test.tsx

adcoelho

Looks great!

kibana-ci · 2023-07-25T17:12:08Z

💚 Build Succeeded

Buildkite Build
Commit: 277eb31

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	422.1KB	422.7KB	+551.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	147.6KB	147.9KB	+255.0B

History

💔 Build #144601 failed ae951cd
💚 Build #144384 succeeded 5c1d653
💔 Build #144334 failed 7994b6f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @js-jankisalvi

…stic#162411) ## Summary Connected to elastic#146945 This PR adds UI validations for `assignees`, `tags` and `categories` filter on cases list table and cases selector modal: Description | Limit | Done? | Documented? | UI? -- | -- | -- | -- | -- Maximum number of assignees to filter | 100 | ✅ | Yes | :white_check_mark: Maximum number of tags to filter | 100 | ✅ | Yes | :white_check_mark: Maximum number of categories to filter | 100 | ✅ | Yes | :white_check_mark: **Selector modal:** ![image](https://github.com/elastic/kibana/assets/117571355/69945b0a-57af-42c0-85e0-7df497d8796b) **Case list table:** ![image](https://github.com/elastic/kibana/assets/117571355/05c882f8-c160-40c3-aa9c-70ad4801e837) ![image](https://github.com/elastic/kibana/assets/117571355/e8e3eef8-81cf-46a2-8c8c-ee0d1f65a8ec) ![image](https://github.com/elastic/kibana/assets/117571355/a30bd780-d36f-437f-bf29-6eafed6accca) _Note:_ _screenshots are taken with 5 as maximum limit for `assignees`, `tags` and `categories` filter:_ ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

js-jankisalvi added 3 commits July 20, 2023 15:39

add validation fir max filter length for assignees and tags

95d5765

Merge remote-tracking branch 'upstream/main' into ui-validation-for-f…

5d0cf94

…ilters

add tests, category validation

4e9ea30

js-jankisalvi added release_note:breaking Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.10.0 labels Jul 24, 2023

js-jankisalvi requested a review from a team as a code owner July 24, 2023 14:06

js-jankisalvi self-assigned this Jul 24, 2023

js-jankisalvi changed the title ~~UI validation for filters~~ [Cases] UI validation for assignees, tags and categories filters Jul 24, 2023

js-jankisalvi added 2 commits July 24, 2023 16:28

Added border to warning

7994b6f

Merge branch 'main' into ui-validation-for-filters

5c1d653

cnasikas approved these changes Jul 25, 2023

View reviewed changes

adcoelho reviewed Jul 25, 2023

View reviewed changes

x-pack/plugins/cases/public/components/filter_popover/index.tsx Outdated Show resolved Hide resolved

adcoelho reviewed Jul 25, 2023

View reviewed changes

x-pack/plugins/cases/public/components/all_cases/assignees_filter.test.tsx Show resolved Hide resolved

adcoelho approved these changes Jul 25, 2023

View reviewed changes

js-jankisalvi added 2 commits July 25, 2023 14:06

PR feedback

ae951cd

Merge branch 'main' into ui-validation-for-filters

277eb31

cnasikas mentioned this pull request Jul 25, 2023

[Cases] Guardrails in Cases APIs #146945

Closed

js-jankisalvi merged commit 22dc782 into elastic:main Jul 26, 2023

kibanamachine added the backport:skip This commit does not require backporting label Jul 26, 2023

js-jankisalvi deleted the ui-validation-for-filters branch February 19, 2024 11:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] UI validation for assignees, tags and categories filters #162411

[Cases] UI validation for assignees, tags and categories filters #162411

js-jankisalvi commented Jul 24, 2023 •

edited

Loading

elasticmachine commented Jul 24, 2023

elasticmachine commented Jul 24, 2023

cnasikas left a comment

adcoelho Jul 25, 2023

js-jankisalvi Jul 25, 2023

adcoelho Jul 25, 2023

js-jankisalvi Jul 25, 2023

cnasikas Jul 27, 2023 •

edited

Loading

adcoelho left a comment

kibana-ci commented Jul 25, 2023

[Cases] UI validation for assignees, tags and categories filters #162411

[Cases] UI validation for assignees, tags and categories filters #162411

Conversation

js-jankisalvi commented Jul 24, 2023 • edited Loading

Summary

Checklist

For maintainers

Release notes

elasticmachine commented Jul 24, 2023

elasticmachine commented Jul 24, 2023

cnasikas left a comment

Choose a reason for hiding this comment

adcoelho Jul 25, 2023

Choose a reason for hiding this comment

js-jankisalvi Jul 25, 2023

Choose a reason for hiding this comment

adcoelho Jul 25, 2023

Choose a reason for hiding this comment

js-jankisalvi Jul 25, 2023

Choose a reason for hiding this comment

cnasikas Jul 27, 2023 • edited Loading

Choose a reason for hiding this comment

adcoelho left a comment

Choose a reason for hiding this comment

kibana-ci commented Jul 25, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

js-jankisalvi commented Jul 24, 2023 •

edited

Loading

cnasikas Jul 27, 2023 •

edited

Loading