[Cases] Make metrics routes internal #162506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:breaking
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
reviewed
Jul 27, 2023
Fixed failing tests that were using the old url. Corrected types for single case metrics features.
adcoelho
force-pushed
the
make-metrics-internals
branch
from
d0d5180 to
883dfd0
Compare
2 tasks
machadoum
approved these changes
Aug 1, 2023
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @adcoelho |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
Fixes elastic#162406 ## Summary - Made `getCaseMetrics` and `getCasesMetrics` internal APIs. - There was no documentation to begin with so there was none to remove. - The allowed/available `features` now come from the `CaseMetricsFeature` _enum_ instead of being hardcoded everywhere. - We now **also** check for the values passed to the `features` field in case metrics requests using io-ts. - There was already some validation before which I decided to leave. When doing `buildHandlers` the function `checkAndThrowIfInvalidFeatures` is always called. Right now, this is only used by `getCasesMetrics` and `getCaseMetrics` where we already decode the params so that validation is redundant, but if it starts being used somewhere else it will be nice to have this extra security guarantee. ### Release Notes The get case metrics APIs are now internal. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162406
Summary
getCaseMetricsandgetCasesMetricsinternal APIs.featuresnow come from theCaseMetricsFeatureenum instead of being hardcoded everywhere.featuresfield in case metrics requests using io-ts.buildHandlersthe functioncheckAndThrowIfInvalidFeaturesis always called. Right now, this is only used bygetCasesMetricsandgetCaseMetricswhere we already decode the params so that validation is redundant, but if it starts being used somewhere else it will be nice to have this extra security guarantee.Release Notes
The get case metrics APIs are now internal.