Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chrome UI] Fix background color in serverless #164419

Merged
merged 2 commits into from
Aug 23, 2023
Merged

[Chrome UI] Fix background color in serverless #164419

merged 2 commits into from
Aug 23, 2023

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Aug 22, 2023 •
edited
Loading

In this PR I've added the required panelled prop to the EuiPageTemplate to get the same white background than in stateful Kibana. The prop was fixed in EUI in elastic/eui#7044 and released in 87.1.0 (#163961)

While testing I've found other UI inconsistencies and opened #164415.

Screenshots

Screenshot 2023-08-22 at 11 45 35 Screenshot 2023-08-22 at 11 45 24 Screenshot 2023-08-22 at 11 45 14

Fixes #160640

@sebelga sebelga added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Aug 22, 2023
@sebelga sebelga self-assigned this Aug 22, 2023
@sebelga sebelga marked this pull request as ready for review August 22, 2023 10:52
@sebelga sebelga requested a review from a team August 22, 2023 10:52
@sebelga sebelga requested a review from a team as a code owner August 22, 2023 10:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@sebelga sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Aug 22, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
management 42.4KB 42.5KB +12.0B
serverlessSearch 72.8KB 72.8KB +12.0B
total +24.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

alisonelizabeth
alisonelizabeth approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment Management changes LGTM. Thanks for fixing this @sebelga!

@alisonelizabeth
Copy link
Contributor

alisonelizabeth commented Aug 22, 2023 •
edited
Loading

Maybe I'm still getting used to it 😅 but the Management landing page looks a little weird with the white page header/page background + white cards + white sidenav. I guess this is somewhat related to #164415.

Screenshot 2023-08-22 at 1 08 34 PM

@sebelga
Copy link
Contributor Author

sebelga commented Aug 23, 2023

Thanks for the review @alisonelizabeth !

the Management landing page looks a little weird with the white page header/page background + white cards + white sidenav

Yes I agree that there is, IMO, a lack of contrast. cc @MichaelMarcialis in case you have some input

@sebelga sebelga enabled auto-merge (squash) August 23, 2023 08:03
efegurkan
efegurkan approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only

@sebelga sebelga merged commit 227fc09 into elastic:main Aug 23, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Aug 23, 2023
@sebelga sebelga deleted the serverless/fix-background-color branch August 23, 2023 09:23
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 23, 2023
@jloleysens
Merge branch 'main' into zdt-test-harness
fab26f8 
* main: (150 commits)
  Fixes unnecessary autocompletes on HTTP methods (elastic#163233)
  [Defend Workflows] Convert filterQuery to kql  (elastic#161806)
  [Fleet] copy `inactivity_timeout` when duplicating agent policy (elastic#164544)
  Fix 7.17 forward compatibility with 8.2+ (elastic#164274)
  [ML] Fixes dark mode in flyouts and modals (elastic#164399)
  [Defend Workflows]Changes to policy settings are not persistent until a refresh (elastic#164403)
  [Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (elastic#164329)
  Prepare the Security domain HTTP APIs for Serverless (elastic#162087)
  skip failing test suite (elastic#160986)
  [Security Solution] Fix flaky Event Filters test (elastic#164473)
  [EDR workflows] Osquery serverless tests (elastic#163795)
  [Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (elastic#164469)
  [Chrome UI] Fix background color in serverless (elastic#164419)
  [DOCS] Saved objects - resolve import errors API (elastic#162825)
  Remove 'Create Rule' button from Rule Group page (elastic#164167)
  [Security Solution] expandable flyout - fix infinite loop in correlations (elastic#163450)
  [Remote Clusters] Update copy about port help text (elastic#164442)
  [api-docs] 2023-08-23 Daily api_docs build (elastic#164524)
  [data views] Disable scripted fields in serverless environment (elastic#163228)
  [Reporting] Fix - show diagnostic only when image reporting is enabled (elastic#164336)
  ...
@MichaelMarcialis
Copy link
Contributor

the Management landing page looks a little weird with the white page header/page background + white cards + white sidenav

Yes I agree that there is, IMO, a lack of contrast. cc @MichaelMarcialis in case you have some input

The designs for this page have always suggested the use of the gray body background (euiTheme.colors.body). It appears that isn't being used here, and white is being used instead. Unless there is a reason to deviate from the designs, I suggest switching to that gray background for the management hub page.

@sebelga sebelga mentioned this pull request Aug 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@efegurkan efegurkan efegurkan approved these changes

Assignees

@sebelga sebelga

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with the page background colour and the app background colour
7 participants
@sebelga @elasticmachine @kibana-ci @alisonelizabeth @MichaelMarcialis @efegurkan @kibanamachine