= ({ return ( } - hasBorder + hasBorder={false} title={

Date: Tue, 5 Sep 2023 14:23:42 +0200 Subject: [PATCH 2/7] [Discover] Update field list styles --- .../kbn-unified-data-table/src/components/data_table.scss | 4 ++++ .../src/components/field_item_button/field_item_button.scss | 4 ++++ .../src/components/field_list_filters/field_name_search.tsx | 1 + 3 files changed, 9 insertions(+) diff --git a/packages/kbn-unified-data-table/src/components/data_table.scss b/packages/kbn-unified-data-table/src/components/data_table.scss index 8b0f8719a450f..6ce913040f5dc 100644 --- a/packages/kbn-unified-data-table/src/components/data_table.scss +++ b/packages/kbn-unified-data-table/src/components/data_table.scss @@ -57,6 +57,10 @@ flex-direction: column; flex-wrap: nowrap; height: 100%; + + .euiDataGrid__content { + background: transparent; + } } .unifiedDataTable__table { diff --git a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss index 70073c37ea31c..b6d04b6a79699 100644 --- a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss +++ b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss @@ -64,6 +64,10 @@ opacity: 1; } } + + &.domDragDrop-isDraggable { + box-shadow: none; + } } .unifiedFieldListItemButton--missing { diff --git a/packages/kbn-unified-field-list/src/components/field_list_filters/field_name_search.tsx b/packages/kbn-unified-field-list/src/components/field_list_filters/field_name_search.tsx index 91d78850e4453..67eb85b4b7849 100644 --- a/packages/kbn-unified-field-list/src/components/field_list_filters/field_name_search.tsx +++ b/packages/kbn-unified-field-list/src/components/field_list_filters/field_name_search.tsx @@ -52,6 +52,7 @@ export const FieldNameSearch: React.FC = ({ placeholder={searchPlaceholder} value={nameFilter} append={append} + compressed /> ); }; From f5d1996dcf20c36b82cb5a70c8242120d443376d Mon Sep 17 00:00:00 2001 From: Julia Rechkunova Date: Tue, 5 Sep 2023 14:36:14 +0200 Subject: [PATCH 3/7] [Discover] Update Add Field button --- .../field_list_sidebar.tsx | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/kbn-unified-field-list/src/containers/unified_field_list_sidebar/field_list_sidebar.tsx b/packages/kbn-unified-field-list/src/containers/unified_field_list_sidebar/field_list_sidebar.tsx index 12eb7209cd05a..d0fe5b9bd88a4 100644 --- a/packages/kbn-unified-field-list/src/containers/unified_field_list_sidebar/field_list_sidebar.tsx +++ b/packages/kbn-unified-field-list/src/containers/unified_field_list_sidebar/field_list_sidebar.tsx @@ -9,7 +9,8 @@ import './field_list_sidebar.scss'; import React, { memo, useCallback, useEffect, useMemo, useState } from 'react'; import { i18n } from '@kbn/i18n'; -import { EuiButton, EuiFlexGroup, EuiFlexItem, EuiPageSidebar } from '@elastic/eui'; +import { EuiFlexGroup, EuiFlexItem, EuiPageSidebar } from '@elastic/eui'; +import { ToolbarButton } from '@kbn/shared-ux-button-toolbar'; import { type DataViewField } from '@kbn/data-views-plugin/public'; import { getDataViewFieldSubtypeMulti } from '@kbn/es-query/src/utils'; import { FIELDS_LIMIT_SETTING, SEARCH_FIELDS_FROM_SOURCE } from '@kbn/discover-utils'; @@ -295,19 +296,18 @@ export const UnifiedFieldListSidebarComponent: React.FC - onEditField()} size="s" - > - {i18n.translate('unifiedFieldList.fieldListSidebar.addFieldButtonLabel', { - defaultMessage: 'Add a field', - })} - + /> )} From 9a139e35e3e580f5173f1b0a0276cffef0ca875d Mon Sep 17 00:00:00 2001 From: Julia Rechkunova Date: Tue, 5 Sep 2023 14:45:45 +0200 Subject: [PATCH 4/7] [Discover] Remove tabs background --- .../public/components/view_mode_toggle/view_mode_toggle.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/plugins/discover/public/components/view_mode_toggle/view_mode_toggle.tsx b/src/plugins/discover/public/components/view_mode_toggle/view_mode_toggle.tsx index b897ea278ebab..475d65d20f056 100644 --- a/src/plugins/discover/public/components/view_mode_toggle/view_mode_toggle.tsx +++ b/src/plugins/discover/public/components/view_mode_toggle/view_mode_toggle.tsx @@ -10,7 +10,6 @@ import { EuiTabs, EuiTab, useEuiPaddingSize } from '@elastic/eui'; import React from 'react'; import { FormattedMessage } from '@kbn/i18n-react'; import { css } from '@emotion/react'; -import { euiThemeVars } from '@kbn/ui-theme'; import { SHOW_FIELD_STATISTICS } from '@kbn/discover-utils'; import { VIEW_MODE } from '../../../common/constants'; import { useDiscoverServices } from '../../hooks/use_discover_services'; @@ -26,7 +25,6 @@ export const DocumentViewModeToggle = ({ const tabsCss = css` padding: 0 ${useEuiPaddingSize('s')}; - background-color: ${euiThemeVars.euiPageBackgroundColor}; `; const showViewModeToggle = uiSettings.get(SHOW_FIELD_STATISTICS) ?? false; From 2eddea685327fd3d124749c95b7572ce84e12330 Mon Sep 17 00:00:00 2001 From: Julia Rechkunova Date: Tue, 5 Sep 2023 14:52:32 +0200 Subject: [PATCH 5/7] [Discover] Apply item shadow changes only for discover --- .../src/components/field_item_button/field_item_button.scss | 2 +- .../src/components/field_item_button/field_item_button.tsx | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss index b6d04b6a79699..e792c3e9b96fc 100644 --- a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss +++ b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss @@ -65,7 +65,7 @@ } } - &.domDragDrop-isDraggable { + &--size-xs.domDragDrop-isDraggable { box-shadow: none; } } diff --git a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.tsx b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.tsx index 13860a0e4f155..3d788e92572b0 100644 --- a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.tsx +++ b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.tsx @@ -105,6 +105,7 @@ export function FieldItemButton({ [`unifiedFieldListItemButton--${type}`]: type, [`unifiedFieldListItemButton--exists`]: !isEmpty, [`unifiedFieldListItemButton--missing`]: isEmpty, + [`unifiedFieldListItemButton--size-${size}`]: true, }, className ); From 15693c960ec0cd9fa59621ec6ac43ad3dbba97a4 Mon Sep 17 00:00:00 2001 From: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Tue, 5 Sep 2023 13:02:03 +0000 Subject: [PATCH 6/7] [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix' --- packages/kbn-unified-field-list/tsconfig.json | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/kbn-unified-field-list/tsconfig.json b/packages/kbn-unified-field-list/tsconfig.json index 78ea71ca44344..f60d203786439 100644 --- a/packages/kbn-unified-field-list/tsconfig.json +++ b/packages/kbn-unified-field-list/tsconfig.json @@ -29,6 +29,7 @@ "@kbn/shared-ux-utility", "@kbn/discover-utils", "@kbn/ebt-tools", + "@kbn/shared-ux-button-toolbar", ], "exclude": ["target/**/*"] } From 1820c3a0b11b4c3f7d185659ff3b42bafc2f9cea Mon Sep 17 00:00:00 2001 From: Julia Rechkunova Date: Tue, 5 Sep 2023 17:06:22 +0200 Subject: [PATCH 7/7] [Discover] Change how shadow is overriden --- .../src/components/field_item_button/field_item_button.scss | 4 ---- .../src/components/field_item_button/field_item_button.tsx | 1 - .../application/main/components/layout/discover_layout.scss | 6 ++++++ .../application/main/components/layout/discover_layout.tsx | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss index e792c3e9b96fc..70073c37ea31c 100644 --- a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss +++ b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss @@ -64,10 +64,6 @@ opacity: 1; } } - - &--size-xs.domDragDrop-isDraggable { - box-shadow: none; - } } .unifiedFieldListItemButton--missing { diff --git a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.tsx b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.tsx index 3d788e92572b0..13860a0e4f155 100644 --- a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.tsx +++ b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.tsx @@ -105,7 +105,6 @@ export function FieldItemButton({ [`unifiedFieldListItemButton--${type}`]: type, [`unifiedFieldListItemButton--exists`]: !isEmpty, [`unifiedFieldListItemButton--missing`]: isEmpty, - [`unifiedFieldListItemButton--size-${size}`]: true, }, className ); diff --git a/src/plugins/discover/public/application/main/components/layout/discover_layout.scss b/src/plugins/discover/public/application/main/components/layout/discover_layout.scss index 8f8f5b8ec8833..a4d4ec2ed7db9 100644 --- a/src/plugins/discover/public/application/main/components/layout/discover_layout.scss +++ b/src/plugins/discover/public/application/main/components/layout/discover_layout.scss @@ -31,6 +31,12 @@ discover-app { overflow: hidden; } +.dscPageBody__sidebar { + .unifiedFieldListItemButton.domDragDrop-isDraggable { + box-shadow: none; + } +} + .dscPageContent__wrapper { overflow: hidden; // Ensures horizontal scroll of table } diff --git a/src/plugins/discover/public/application/main/components/layout/discover_layout.tsx b/src/plugins/discover/public/application/main/components/layout/discover_layout.tsx index 902a6e6c9c0ee..fed1bcbfa79a2 100644 --- a/src/plugins/discover/public/application/main/components/layout/discover_layout.tsx +++ b/src/plugins/discover/public/application/main/components/layout/discover_layout.tsx @@ -285,7 +285,7 @@ export function DiscoverLayout({ stateContainer }: DiscoverLayoutProps) { history={history} /> - +