Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Model state change error handling #172409

Merged
merged 3 commits into from
Dec 2, 2023

Conversation

demjened
Copy link
Contributor

@demjened demjened commented Dec 1, 2023

Summary

This PR adds error handling to model actions (deploy, start) in the ML model selection list. If either of these API calls fail, an error is displayed. The error stays on the screen until the flyout is reopened or another model action succeeds.

Unfortunately there's no straightforward way to surface the root cause, so we display a generic error message to check the Kibana logs (which do contain the cause).

Screenshot 2023-12-01 at 17 50 52

Checklist

@demjened demjened added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.12.0 labels Dec 1, 2023
@demjened demjened marked this pull request as ready for review December 1, 2023 23:04
@demjened demjened requested a review from a team December 1, 2023 23:04
@demjened demjened enabled auto-merge (squash) December 2, 2023 00:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.7MB +525.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@demjened demjened merged commit 7ad94e9 into main Dec 2, 2023
30 checks passed
@demjened demjened deleted the demjened/model-state-change-error-handling branch December 2, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants