Update jest (main) #173227

renovate · 2023-12-12T21:57:11Z

Why was I pinged for review?

It looks like this new version is a bit more sensitive with the global jest.clearAllMocks(), jest.resetAllMocks(), and jest.restoreAllMocks().

My understanding after try-and-error is that spies are only cleared via jest.restoreAllMocks().

This PR contains the following updates:

Package	Type	Update	Change
@jest/console (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
@jest/reporters (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
@jest/types (source)	devDependencies	patch	`^29.6.1` -> `^29.6.3`
babel-jest (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
expect (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
jest (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
jest-cli (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
jest-config (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
jest-diff (source)	devDependencies	patch	`^29.6.1` -> `^29.7.0`
jest-environment-jsdom (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
jest-matcher-utils (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
jest-mock (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
jest-runtime (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`
jest-snapshot (source)	devDependencies	minor	`^29.6.1` -> `^29.7.0`

Release Notes

jestjs/jest (@jest/console)

`v29.7.0`

Compare Source

Features

[create-jest] Add npm init / yarn create initialiser for Jest projects (#14465)
[jest-validate] Allow deprecation warnings for unknown options (#14499)

Fixes

[jest-resolver] Replace unmatched capture groups in moduleNameMapper with empty string instead of undefined (#14507)
[jest-snapshot] Allow for strings as well as template literals in inline snapshots (#14465)
[@jest/test-sequencer] Calculate test runtime if perStats.duration is missing (#14473)

Performance

[@jest/create-cache-key-function] Cache access of NODE_ENV and BABEL_ENV (#14455)

Chore & Maintenance

[jest-cli] Move internal config initialisation logic to the create-jest package (#14465)

`v29.6.4`

Compare Source

Fixes

[jest-core] Fix typo in scheduleAndRun performance marker (#14434)
[jest-environment-node] Make sure atob and btoa are writeable in Node 20 (#14446)
[jest-worker] Additional error wrapper for parentPort.postMessage to fix unhandled DataCloneError. (#14437)

`v29.6.3`

Compare Source

Fixes

[expect, @jest/expect-utils] ObjectContaining support sumbol as key (#14414)
[expect] Remove @types/node from dependencies (#14385)
[jest-core] Use workers in watch mode by default to avoid crashes (#14059 & #14085).
[jest-reporters] Update istanbul-lib-instrument dependency to v6. (#14401)
[jest-mock] Revert #13692 as it was a breaking change (#14429)
[jest-mock] Revert #13866 as it was a breaking change (#14429)
[jest-mock] Revert #13867 as it was a breaking change (#14429)
[@jest/reporters] Marks Reporter's hooks as optional (#14433)
[jest-runtime] Fix dynamic ESM import module bug when loaded module through jest.isolateModulesAsync (#14397)

Chore & Maintenance

[jest-changed-files, jest-circus, jest-console, @jest/core, @jest/runtime, @jest/transform] Use invariant and notEmpty from jest-util rather than own internal (#14366)

`v29.6.2`

Compare Source

Fixes

[jest-circus] Fix snapshot matchers in concurrent tests when nr of tests exceeds maxConcurrency (#14335)
[@jest/core] When running global setup and teardown, do not try to change the message property of the thrown error object when the message property is unwritable (#14113)
[jest-snapshot] Move @types/prettier from dependencies to devDependencies (#14328)
[jest-snapshot] Throw an explicit error if Prettier v3 is used (#14367)
[jest-reporters] Add "skipped" and "todo" symbols to Github Actions Reporter (#14309)

Chore & Maintenance

[@jest/core] Use pluralize from jest-util rather than own internal (#14322)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

elasticmachine · 2023-12-12T21:57:15Z

Pinging @elastic/kibana-operations (Team:Operations)

patrykkopycinski · 2024-05-08T16:17:38Z

/ci

afharo · 2024-06-28T22:38:08Z

/ci

afharo · 2024-06-28T23:04:54Z

/ci

afharo · 2024-08-08T08:48:19Z

/ci

elastic-renovate-prod · 2024-08-08T09:19:11Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

afharo · 2024-08-08T14:02:58Z

/ci

delanni · 2024-08-09T14:10:55Z

/ci

pmuellr

Response Ops changes LGTM

afharo · 2024-08-19T18:45:41Z

/ci

eokoneyo

Shared UX changes LGTM

afharo · 2024-08-23T11:23:10Z

/ci

elasticmachine · 2024-08-23T14:27:28Z

Pinging @elastic/fleet (Team:Fleet)

afharo · 2024-08-23T14:28:29Z

/ci

afharo · 2024-08-23T16:13:21Z

/ci

nchaulet

Fleet changes LGTM 🚀

dmlemeshko · 2024-08-26T09:17:02Z

packages/kbn-test/src/auth/session_manager.test.ts

+  let createCloudSAMLSessionMock: jest.SpyInstance;
+  beforeEach(() => {
+    createCloudSAMLSessionMock = jest.spyOn(samlAuth, 'createCloudSAMLSession');
+  });


@afharo totally fine with the change, but could you explain why it is required after update?
Is there something specific about createCloudSAMLSession function?

I couldn't find anything in the changelogs, but my observation in this PR is that jest changed (broke? 🤷) how spies are reset via the jest.reset/restoreAllMocks and the specific myMock.mockReset/Restore.

This means the pattern global spy + jest.reset/restoreAllMocks didn't work in some cases. I found that recreating the spy on each run was more stable (but lazy me, only changed it for those breaking the tests 😇)

only changed it for those breaking the tests

Thank you! I will update other tests later.

tiansivive

LGTM from Entity analytics

afharo · 2024-08-26T12:57:17Z

/ci

kibana-ci · 2024-08-26T13:50:22Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 3c3a872
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-173227-3c3a87277108

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #57 / InfraOps App Metrics UI Hosts View #With data #Single Host Flyout Tabs Metadata Tab should render metadata tab, add and remove filter
[job] [logs] Jest Tests #17 / rules_list component empty hides MaintenanceWindowCallout if filterConsumers does not match the running maintenance window's category

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

💛 Build #229527 was flaky 209853a
💔 Build #229481 failed a928e6e
💔 Build #229422 failed be642b6
💔 Build #228381 failed 3b2e919
💔 Build #226918 failed 2f46db5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

renovate bot added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team labels Dec 12, 2023

renovate bot requested a review from a team December 12, 2023 21:57

renovate bot force-pushed the renovate/main-jest branch from 101ee23 to a021ff6 Compare May 8, 2024 14:09

renovate bot force-pushed the renovate/main-jest branch 2 times, most recently from bbd7ece to d4c4b36 Compare June 28, 2024 15:45

afharo approved these changes Jun 28, 2024

View reviewed changes

afharo enabled auto-merge (squash) June 28, 2024 23:18

elastic-renovate-prod bot deleted a comment from renovate bot Aug 7, 2024

Update jest

ee1bc55

elastic-renovate-prod bot force-pushed the renovate/main-jest branch from af05ee3 to ee1bc55 Compare August 7, 2024 21:17

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

4250a1c

Merge branch 'main' into renovate/main-jest

99ad616

Fix some tests

18196cc

afharo requested review from a team as code owners August 9, 2024 18:56

afharo added 2 commits August 9, 2024 21:17

Fix another suite

6377221

More tests

5bf0e09

afharo requested review from a team as code owners August 9, 2024 19:41

afharo requested a review from tiansivive August 9, 2024 19:41

synthetics tests

0e4d3f3

nickofthyme approved these changes Aug 13, 2024

View reviewed changes

pmuellr approved these changes Aug 19, 2024

View reviewed changes

afharo added 4 commits August 19, 2024 20:33

Fix percentile.test

bfd6dce

Fix @kbn/test auth session_manager tests

3cfa28b

Remove commented code

0823431

Merge branch 'main' into renovate/main-jest

3b2e919

eokoneyo approved these changes Aug 20, 2024

View reviewed changes

adcoelho approved these changes Aug 20, 2024

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into renovate/main-jest

be642b6

Fix fleet test

b8c6716

afharo requested a review from a team as a code owner August 23, 2024 14:27

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 23, 2024

Merge branch 'main' into renovate/main-jest

a928e6e

reporting: destroy streams in afterEach

209853a

Ikuni17 approved these changes Aug 23, 2024

View reviewed changes

nchaulet approved these changes Aug 23, 2024

View reviewed changes

dmlemeshko reviewed Aug 26, 2024

View reviewed changes

tiansivive approved these changes Aug 26, 2024

View reviewed changes

Merge branch 'main' into renovate/main-jest

3c3a872

afharo merged commit 1397256 into main Aug 26, 2024
51 checks passed

afharo deleted the renovate/main-jest branch August 26, 2024 14:43

kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update jest (main) #173227

Update jest (main) #173227

renovate bot commented Dec 12, 2023 •

edited by afharo

Loading

elasticmachine commented Dec 12, 2023

patrykkopycinski commented May 8, 2024

afharo commented Jun 28, 2024

afharo commented Jun 28, 2024

afharo commented Aug 8, 2024

elastic-renovate-prod bot commented Aug 8, 2024

afharo commented Aug 8, 2024

delanni commented Aug 9, 2024

pmuellr left a comment

afharo commented Aug 19, 2024

eokoneyo left a comment

afharo commented Aug 23, 2024

elasticmachine commented Aug 23, 2024

afharo commented Aug 23, 2024

afharo commented Aug 23, 2024

nchaulet left a comment

dmlemeshko Aug 26, 2024 •

edited

Loading

afharo Aug 26, 2024

dmlemeshko Aug 26, 2024

tiansivive left a comment

afharo commented Aug 26, 2024

kibana-ci commented Aug 26, 2024 •

edited

Loading

Update jest (main) #173227

Update jest (main) #173227

Conversation

renovate bot commented Dec 12, 2023 • edited by afharo Loading

Why was I pinged for review?

Release Notes

v29.7.0

Features

Fixes

Performance

Chore & Maintenance

v29.6.4

Fixes

v29.6.3

Fixes

Chore & Maintenance

v29.6.2

Fixes

Chore & Maintenance

Configuration

elasticmachine commented Dec 12, 2023

patrykkopycinski commented May 8, 2024

afharo commented Jun 28, 2024

afharo commented Jun 28, 2024

afharo commented Aug 8, 2024

elastic-renovate-prod bot commented Aug 8, 2024

Edited/Blocked Notification

afharo commented Aug 8, 2024

delanni commented Aug 9, 2024

pmuellr left a comment

Choose a reason for hiding this comment

afharo commented Aug 19, 2024

eokoneyo left a comment

Choose a reason for hiding this comment

afharo commented Aug 23, 2024

elasticmachine commented Aug 23, 2024

afharo commented Aug 23, 2024

afharo commented Aug 23, 2024

nchaulet left a comment

Choose a reason for hiding this comment

dmlemeshko Aug 26, 2024 • edited Loading

Choose a reason for hiding this comment

afharo Aug 26, 2024

Choose a reason for hiding this comment

dmlemeshko Aug 26, 2024

Choose a reason for hiding this comment

tiansivive left a comment

Choose a reason for hiding this comment

afharo commented Aug 26, 2024

kibana-ci commented Aug 26, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

History

renovate bot commented Dec 12, 2023 •

edited by afharo

Loading

`v29.7.0`

`v29.6.4`

`v29.6.3`

`v29.6.2`

dmlemeshko Aug 26, 2024 •

edited

Loading

kibana-ci commented Aug 26, 2024 •

edited

Loading