Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12] [Security Solution] Disable installation button for users with Security:Read privileges (#176598) #176616

Merged
merged 1 commit into from
Feb 9, 2024

Commits on Feb 9, 2024

  1. [Security Solution] Disable installation button for users with Securi…

    …ty:Read privileges (elastic#176598)
    
    Fixes: elastic#161543
    
    ## Summary
    
    Original bug issue reported an infinite loading state in the **Add
    Elastic rules** page when user doesn't have write privileges, i.e. has
    `Security: Read`.
    
    However, that seems to have been fixed already, as the list of rules to
    install is shown, but no individual "Install button" for each row is
    showed. **This is expected behaviour**.
    
    ![image](https://github.com/elastic/kibana/assets/5354282/f57adc2b-9073-4019-a15e-8c05e48f1b9d)
    
    However, when displaying the Rule Details flyout, the button for
    Installation in the flyout is still enabled due to missing checks. This
    PR fixes that and now displays a disabled button for users with no
    privileges.
    
    ![image](https://github.com/elastic/kibana/assets/5354282/70a6b209-59bb-4199-99f9-f2222fb78d68)
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    (cherry picked from commit c3c1b66)
    jpdjere committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    795bfc5 View commit details
    Browse the repository at this point in the history