diff --git a/src/core_plugins/kibana/public/dashboard/panel/__snapshots__/dashboard_panel.test.js.snap b/src/core_plugins/kibana/public/dashboard/panel/__snapshots__/dashboard_panel.test.js.snap index 67e0af5a90ecc..9f60aa5bc8f1c 100644 --- a/src/core_plugins/kibana/public/dashboard/panel/__snapshots__/dashboard_panel.test.js.snap +++ b/src/core_plugins/kibana/public/dashboard/panel/__snapshots__/dashboard_panel.test.js.snap @@ -10,13 +10,16 @@ exports[`DashboardPanel matches snapshot 1`] = ` >
+ title="my embeddable title" + > + my embeddable title +
diff --git a/src/core_plugins/kibana/public/dashboard/panel/dashboard_panel.test.js b/src/core_plugins/kibana/public/dashboard/panel/dashboard_panel.test.js index c0f363181881c..787c688a0ac16 100644 --- a/src/core_plugins/kibana/public/dashboard/panel/dashboard_panel.test.js +++ b/src/core_plugins/kibana/public/dashboard/panel/dashboard_panel.test.js @@ -11,6 +11,7 @@ import { updateViewMode, setPanels, updateTimeRange, + embeddableIsInitialized, } from '../actions'; import { Provider } from 'react-redux'; @@ -37,6 +38,8 @@ beforeAll(() => { store.dispatch(updateTimeRange({ to: 'now', from: 'now-15m' })); store.dispatch(updateViewMode(DashboardViewMode.EDIT)); store.dispatch(setPanels({ 'foo1': { panelIndex: 'foo1' } })); + const metadata = { title: 'my embeddable title', editUrl: 'editme' }; + store.dispatch(embeddableIsInitialized({ metadata, panelId: 'foo1' })); }); test('DashboardPanel matches snapshot', () => { diff --git a/src/core_plugins/kibana/public/dashboard/panel/panel_header/panel_header.js b/src/core_plugins/kibana/public/dashboard/panel/panel_header/panel_header.js index b61f3b4a77688..593a523feab1c 100644 --- a/src/core_plugins/kibana/public/dashboard/panel/panel_header/panel_header.js +++ b/src/core_plugins/kibana/public/dashboard/panel/panel_header/panel_header.js @@ -13,7 +13,7 @@ export function PanelHeader({ title, actions, isViewOnlyMode, hidePanelTitles }) } return ( -
+
-

+

Add Panels

diff --git a/src/core_plugins/metrics/public/components/no_data.js b/src/core_plugins/metrics/public/components/no_data.js index b7040b8c85f6b..6a7c1985f4c72 100644 --- a/src/core_plugins/metrics/public/components/no_data.js +++ b/src/core_plugins/metrics/public/components/no_data.js @@ -2,7 +2,7 @@ import React from 'react'; function NoDataComponent() { return ( -
+
No data to display for the selected metrics .
); diff --git a/src/core_plugins/metrics/public/components/vis_types/markdown/vis.js b/src/core_plugins/metrics/public/components/vis_types/markdown/vis.js index 81eebed3a1718..487d09fe4ab7c 100644 --- a/src/core_plugins/metrics/public/components/vis_types/markdown/vis.js +++ b/src/core_plugins/metrics/public/components/vis_types/markdown/vis.js @@ -34,7 +34,7 @@ function MarkdownVisualization(props) { if (reversed) className += ' reversed'; const markdownError = markdownSource instanceof Error ? markdownSource : null; markdown = ( -
+
{markdownError && }
diff --git a/src/core_plugins/metrics/public/visualizations/components/metric.js b/src/core_plugins/metrics/public/visualizations/components/metric.js index eead38f5303b7..0194ecda447f7 100644 --- a/src/core_plugins/metrics/public/visualizations/components/metric.js +++ b/src/core_plugins/metrics/public/visualizations/components/metric.js @@ -135,7 +135,13 @@ class Metric extends Component {
this.inner = el} className="rhythm_metric__inner" style={styles.inner}>
{ primaryLabel } -
{ primaryValue }
+
+ { primaryValue } +
{ secondarySnippet } {additionalLabel} diff --git a/src/core_plugins/metrics/public/visualizations/components/top_n.js b/src/core_plugins/metrics/public/visualizations/components/top_n.js index a1c3ebd6bfedc..abe10949314e6 100644 --- a/src/core_plugins/metrics/public/visualizations/components/top_n.js +++ b/src/core_plugins/metrics/public/visualizations/components/top_n.js @@ -47,7 +47,7 @@ class TopN extends Component { style={styles.innerBar} /> - { value } + { value } ); }; diff --git a/src/core_plugins/metrics/public/visualizations/lib/create_legend_series.js b/src/core_plugins/metrics/public/visualizations/lib/create_legend_series.js index 5f3beb38f9335..a8cf51f4c834c 100644 --- a/src/core_plugins/metrics/public/visualizations/lib/create_legend_series.js +++ b/src/core_plugins/metrics/public/visualizations/lib/create_legend_series.js @@ -17,6 +17,7 @@ export default props => (row, i) => {