Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Investigate] Create plugin #184908

Merged

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Jun 6, 2024

Create the Investigate plugin (naming TBD). Part of #183293, splitting up the work in several PRs.

The investigate plugin is mostly a registry to allow plugins to register their widgets without creating dependency issues.

@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Jun 6, 2024
@dgieselaar dgieselaar requested review from a team as code owners June 6, 2024 08:56
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Jun 6, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 6, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
investigate - 12 +12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
investigate - 95 +95
observabilityAIAssistant 258 259 +1
total +96

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5499 +5499
total size - 8.9MB +8.9MB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
investigate - 4 +4
observabilityAIAssistant 26 27 +1
total +5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
investigate - 2.8KB +2.8KB
Unknown metric groups

API count

id before after diff
investigate - 95 +95
observabilityAIAssistant 260 261 +1
total +96

ESLint disabled in files

id before after diff
investigate - 2 +2

Total ESLint disabled count

id before after diff
investigate - 2 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Comment on lines +18 to +19
datasourceState?: V;
datasourceId?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should source be capitalized?

Suggested change
datasourceState?: V;
datasourceId?: string;
dataSourceState?: V;
dataSourceId?: string;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just copy pasted a type from the Lens plugin, it's not ours!

@dgieselaar dgieselaar merged commit 15b6ba9 into elastic:main Jun 7, 2024
39 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants