-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Investigate] Create plugin #184908
[Investigate] Create plugin #184908
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Canvas Sharable Runtime
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
Total ESLint disabled count
HistoryTo update your PR or re-run it, just comment with: |
datasourceState?: V; | ||
datasourceId?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should source be capitalized?
datasourceState?: V; | |
datasourceId?: string; | |
dataSourceState?: V; | |
dataSourceId?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just copy pasted a type from the Lens plugin, it's not ours!
Create the Investigate plugin (naming TBD). Part of #183293, splitting up the work in several PRs.
The investigate plugin is mostly a registry to allow plugins to register their widgets without creating dependency issues.