[Obs AI Assistant] Boost user prompt in recall #184933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
WDYT about making |
That's not a bad idea. I'll do that. |
…pt-over-screen-description # Conflicts: # x-pack/plugins/observability_solution/observability_ai_assistant/server/service/client/index.ts
sorenlouv
commented
Jun 7, 2024
Comment on lines
-120
to
+85
| queries: queriesOrUserPrompt, | ||
| screenDescription, | ||
| userPrompt, |
There was a problem hiding this comment.
@dgieselaar Per your comment we now use queries that includes boost parameter in recall but for scoring suggestions I am getting better results by telling the LLM what each query is (user prompt and screen description).
There was a problem hiding this comment.
Actually that's a great idea!
|
/ci |
dgieselaar
approved these changes
Jun 8, 2024
botelastic
bot
added
ci:project-deploy-observability
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Canvas Sharable Runtime
Page load bundle
History
To update your PR or re-run it, just comment with: |
delanni
added a commit
to delanni/kibana
that referenced
this pull request
Jun 10, 2024
This reverts commit baa22bb.
dgieselaar
added a commit
that referenced
this pull request
Jun 10, 2024
In #184933, we removed the parameters for the `context` function, however, OpenAI requires at least an empty `arguments` object, so requests fail. This PR sets arguments to an empty JSON object (`"{}"`) if `function_call.arguments` is empty.
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Jun 13, 2024
Closes: elastic#180995 --------- Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
sorenlouv
added
v8.14.2
and removed
backport:skip
sorenlouv
added
the
auto-backport
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sorenlouv
removed
the
auto-backport
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Jul 1, 2024
Closes: elastic#180995 --------- Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> (cherry picked from commit baa22bb) # Conflicts: # x-pack/plugins/observability_solution/observability_ai_assistant/server/service/client/get_context_function_request_if_needed.ts # x-pack/plugins/observability_solution/observability_ai_assistant/server/service/client/index.test.ts # x-pack/plugins/observability_solution/observability_ai_assistant/server/service/client/index.ts # x-pack/plugins/observability_solution/observability_ai_assistant_app/public/components/chat/chat_body.test.tsx
sorenlouv
added a commit
that referenced
this pull request
Jul 2, 2024
) # Backport This will backport the following commits from `main` to `8.14`: - [[Obs AI Assistant] Boost user prompt in recall (#184933)](#184933) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2024-06-08T20:32:49Z","message":"[Obs AI Assistant] Boost user prompt in recall (#184933)\n\nCloses: https://github.com/elastic/kibana/issues/180995\r\n\r\n---------\r\n\r\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>","sha":"baa22bb16a179f7c5f13caf06afca315f62d0746","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","Team:Obs AI Assistant","ci:project-deploy-observability","v8.15.0","v8.14.2"],"title":"[Obs AI Assistant] Boost user prompt in recall","number":184933,"url":"https://github.com/elastic/kibana/pull/184933","mergeCommit":{"message":"[Obs AI Assistant] Boost user prompt in recall (#184933)\n\nCloses: https://github.com/elastic/kibana/issues/180995\r\n\r\n---------\r\n\r\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>","sha":"baa22bb16a179f7c5f13caf06afca315f62d0746"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/184933","number":184933,"mergeCommit":{"message":"[Obs AI Assistant] Boost user prompt in recall (#184933)\n\nCloses: https://github.com/elastic/kibana/issues/180995\r\n\r\n---------\r\n\r\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>","sha":"baa22bb16a179f7c5f13caf06afca315f62d0746"}},{"branch":"8.14","label":"v8.14.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
|
This PR didn't make it on time to be included in the latest BC for v8.14.2. |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jul 18, 2024
In elastic#184933, we removed the parameters for the `context` function, however, OpenAI requires at least an empty `arguments` object, so requests fail. This PR sets arguments to an empty JSON object (`"{}"`) if `function_call.arguments` is empty. (cherry picked from commit 8f3359c)
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Dec 10, 2024
Closes: elastic#180995 --------- Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> (cherry picked from commit baa22bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #180995