-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] Fix broken i18n messages #185011
[i18n] Fix broken i18n messages #185011
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML edit LGTM
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Canvas Sharable Runtime
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Management team changes LGTM (Console & UA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vis code changes LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question; maybe I set it up wrong though
We are making an exception and force-merging this as @Bamieh previously communicated:
|
Summary
We have recently upgraded the i18n packages which has some breaking changes.
The tooling upgrade to ensure that no malformed strings are in the codebase is still in progress.
The new code for the
i18n_check
is ready and I used it againstmain
to detect all i18n issues we currently have in the codebase.These are the resulting fixes we need to have in place.
I am doing this before the i18n tools are merged into main to give the core team the time to merge the PR without rushing into the code review. Additionally this ensures that the next serverless release does not contain any malformed strings.
Please filter code by team and check the changes.
The changes are:
ignoreTag: true
where there is xml like tags that are not HTML.other
case toplural
andselect
ICUFor more details about the i18n changes: