-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Anomaly Detection: Adds popover links menu to anomaly explorer charts. #186587
Merged
walterra
merged 22 commits into
elastic:main
from
walterra:ml-ad-ae-anomaly-charts-popover
Sep 19, 2024
Merged
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7b10f35
adds popover links menu to anomaly explorer charts
walterra c003f34
fix RuleEditorFlyout
walterra a934e95
add popover to ExplorerChartDistribution
walterra cb9ee0f
show view series actions
walterra 0ae1576
fix embeddings
walterra f07cdb4
fix popover in embeddings
walterra db0bd6f
fix link to single metric viewer
walterra e35c568
fix mlJobService
walterra 6cff8ba
fix types
walterra 7829012
fix click on multi bucket anomalies
walterra aea101d
Merge branch 'main' into ml-ad-ae-anomaly-charts-popover
walterra 2ffbaa4
Merge branch 'main' into ml-ad-ae-anomaly-charts-popover
walterra 19ba311
fix dependencies
walterra 79ec10b
Merge branch 'main' into ml-ad-ae-anomaly-charts-popover
walterra 4959864
revert links_menu.tsx formatting
walterra 4e1e8af
Merge branch 'main' into ml-ad-ae-anomaly-charts-popover
walterra 270b75f
Merge branch 'main' into ml-ad-ae-anomaly-charts-popover
walterra 5ac1cbb
getTableItemClosestToTimestamp
walterra 5117507
useMlJobService
walterra 8e8185b
fix multiple detectors
walterra d7488d2
update x-pack/plugins/ml/tsconfig.json
walterra 2b7d099
Merge branch 'main' into ml-ad-ae-anomaly-charts-popover
walterra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to be addressed in this PR but I think we should move away from this pattern of having a child set a parent component setter since it's an antipattern. I know this is old code and this is the way it's done in the Rule editor flyout currently but just think we should add this to the list of things to improve.