Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17][EMS] Update to ems-client@7.17.2 #187672

Closed
wants to merge 2 commits into from
Closed

[7.17][EMS] Update to ems-client@7.17.2 #187672

wants to merge 2 commits into from

Conversation

jsanz
Copy link
Member

@jsanz jsanz commented Jul 5, 2024 •
edited
Loading

This is a maintenace update of ems-client to 7.17.2.

A similar PR will be also open to the main branch for 8.5.2.

@jsanz jsanz added Feature:Maps release_note:skip Skip the PR/issue when compiling release notes v7.17.23 labels Jul 5, 2024
@jsanz jsanz requested a review from nickpeihl July 5, 2024 13:09
@jsanz jsanz marked this pull request as ready for review July 5, 2024 13:09
@jsanz
Copy link
Member Author

jsanz commented Jul 5, 2024

/ci

nickpeihl
nickpeihl approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review

@jsanz
Copy link
Member Author

jsanz commented Jul 9, 2024

@elasticmachine merge upstream

@jsanz jsanz added the ci:cloud-deploy Create or update a Cloud deployment label Jul 9, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB -3.3KB
mapsEms 237.6KB 234.3KB -3.3KB
visTypeVega 1.7MB 1.7MB -3.3KB
total -9.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
kibana 868 872 +4

History

@jsanz
Copy link
Member Author

jsanz commented Jul 10, 2024

@nickpeihl sorry for the noise but after comment yesterday I think I'm going to play safe, and I'm going to align all ems-client dependencies with Kibana ones (per branch).

@jsanz jsanz closed this Jul 10, 2024
@jsanz jsanz deleted the update/ems-client branch July 10, 2024 10:39
@jsanz jsanz mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
ci:cloud-deploy Create or update a Cloud deployment Feature:Maps release_note:skip Skip the PR/issue when compiling release notes v7.17.23
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsanz @elasticmachine @nickpeihl