[7.17] chore(NA): remove usage of re2 and replace it with a non native module (#188134) #188369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic#188134) This PR removes the usage of the native module version of `re2` and replaces it with a js port called `re2js`. It also ends our usage of native node modules in production and it removes the task from the build as well. Further steps will be taken along our strategy to avoid future usages of native node modules in prod environments. (cherry picked from commit 3c338a8) # Conflicts: # kbn_pm/src/lib/bazel.mjs # package.json # renovate.json # src/dev/build/tasks/install_dependencies_task.ts # src/dev/build/tasks/patch_native_modules_task.ts # yarn.lock
|
Waiting for #188372 before rebase |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
adelisle
pushed a commit
to Makila-AI/kibana
that referenced
this pull request
Aug 5, 2024
…e module (elastic#188134) (elastic#188369) # Backport This will backport the following commits from `main` to `7.17`: - [chore(NA): remove usage of re2 and replace it with a non native module (elastic#188134)](elastic#188134) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"tiago.costa@elastic.co"},"sourceCommit":{"committedDate":"2024-07-15T19:33:28Z","message":"chore(NA): remove usage of re2 and replace it with a non native module (elastic#188134)\n\nThis PR removes the usage of the native module version of `re2` and\r\nreplaces it with a js port called `re2js`.\r\nIt also ends our usage of native node modules in production and it\r\nremoves the task from the build as well. Further steps will be taken\r\nalong our strategy to avoid future usages of native node modules in prod\r\nenvironments.","sha":"3c338a82c2d6d59c91f0f3b74f725231c69c5b13","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.16.0"],"number":188134,"url":"https://github.com/elastic/kibana/pull/188134","mergeCommit":{"message":"chore(NA): remove usage of re2 and replace it with a non native module (elastic#188134)\n\nThis PR removes the usage of the native module version of `re2` and\r\nreplaces it with a js port called `re2js`.\r\nIt also ends our usage of native node modules in production and it\r\nremoves the task from the build as well. Further steps will be taken\r\nalong our strategy to avoid future usages of native node modules in prod\r\nenvironments.","sha":"3c338a82c2d6d59c91f0f3b74f725231c69c5b13"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188134","number":188134,"mergeCommit":{"message":"chore(NA): remove usage of re2 and replace it with a non native module (elastic#188134)\n\nThis PR removes the usage of the native module version of `re2` and\r\nreplaces it with a js port called `re2js`.\r\nIt also ends our usage of native node modules in production and it\r\nremoves the task from the build as well. Further steps will be taken\r\nalong our strategy to avoid future usages of native node modules in prod\r\nenvironments.","sha":"3c338a82c2d6d59c91f0f3b74f725231c69c5b13"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.17:Questions ?
Please refer to the Backport tool documentation