Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Implement OrderExpression for SORT command arguments #189796

Closed
wants to merge 1 commit into from

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Aug 2, 2024

Summary

Closes #189491

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@vadimkibana
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 2, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #18 / correctQueryWithActions doesnt complain for @timestamp column
  • [job] [logs] Jest Tests #18 / correctQueryWithActions doesnt complain for @timestamp column
  • [job] [logs] FTR Configs #13 / machine learning - anomaly detection forecasts with single metric job displays job results
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort "field" => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort "field" => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort "field" asc => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort "field" asc => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort "field" desc => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort "field" desc => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc first => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc first => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc last => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc last => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc nulls => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc nulls => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc nulls first => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc nulls first => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc nulls last => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField asc nulls last => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc first => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc first => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc last => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc last => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc nulls => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc nulls => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc nulls first => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc nulls first => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc nulls last => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField desc nulls last => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField nulls first => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField nulls first => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField, => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField, => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField, textField => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort doubleField, textField => 0 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort wrongField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #13 / validation logic Full validation performed sort from a_index | sort wrongField => 1 errors, 0 warnings

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.3MB 3.3MB +153.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich force-pushed the esql-order-expression branch from fd55752 to 89a8e0b Compare August 6, 2024 09:57
@vadimkibana vadimkibana closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ES|QL] Introduce OrderExpression nodes { type: 'order' }
2 participants