Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose privilege API client to spaces #189819

Merged

Conversation

eokoneyo
Copy link
Contributor

@eokoneyo eokoneyo commented Aug 2, 2024

Summary

Expose privilege API client to be injected into the spaces app, to facilitate new spaces UX

@eokoneyo eokoneyo added the release_note:skip Skip the PR/issue when compiling release notes label Aug 2, 2024
@eokoneyo eokoneyo self-assigned this Aug 2, 2024
@eokoneyo eokoneyo force-pushed the chore/expose-privilege-api-client-to-spaces branch from bb83001 to bab994a Compare August 5, 2024 10:14
@eokoneyo eokoneyo added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Aug 13, 2024
@eokoneyo eokoneyo force-pushed the chore/expose-privilege-api-client-to-spaces branch 4 times, most recently from 71f0901 to b1f8f24 Compare August 23, 2024 13:59
@eokoneyo eokoneyo marked this pull request as ready for review August 23, 2024 14:01
@eokoneyo eokoneyo requested a review from a team as a code owner August 23, 2024 14:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@eokoneyo
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@eokoneyo
Copy link
Contributor Author

@elasticmachine merge upstream

@eokoneyo eokoneyo force-pushed the chore/expose-privilege-api-client-to-spaces branch from 059959a to ffef237 Compare August 26, 2024 09:46
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
security 523 526 +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/security-plugin-types-public 25 31 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 589.4KB 588.6KB -752.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
security 66.6KB 67.3KB +705.0B
spaces 29.4KB 29.6KB +264.0B
total +969.0B
Unknown metric groups

API count

id before after diff
@kbn/security-plugin-types-public 51 58 +7
security 447 448 +1
total +8

async chunk count

id before after diff
security 22 21 -1

History

  • 💚 Build #229525 succeeded 40b4b1f0f644b7915663affb8418261a1d8521c9
  • 💔 Build #229475 failed b1f8f2467f447455705d5758397e89cd226c6f1d
  • 💔 Build #229424 failed 71f09010ee1c5519d2411ca7ee4640ed4a9c603f
  • 💔 Build #229411 failed f28b39f7c5e6696f4909d655b79870c7039eb631
  • 💔 Build #229383 failed 6e0f0ad3b70c3d30933dcdb81052595df32d1c48
  • 💔 Build #229364 failed 7b663108149cdcab9488153f16ae6792fc134b10

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @eokoneyo

@eokoneyo eokoneyo merged commit 90f2eb3 into elastic:main Aug 27, 2024
21 checks passed
@eokoneyo eokoneyo deleted the chore/expose-privilege-api-client-to-spaces branch August 27, 2024 13:56
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants