[Security Solution][Entity details] - move managed user code to flyout folder #190107
Conversation
PhilippeOberti
added
release_note:skip
PhilippeOberti
force-pushed
the
manage-user-to-flyout
branch
2 times, most recently
from
22d5a6f to
b076821
Compare
|
buildkite test this |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
| @@ -10,7 +10,7 @@ import { useObservedHostFields } from './use_observed_host_fields'; | |||
| import { mockObservedHostData } from '../../mocks'; | |||
| import { TestProviders } from '../../../../common/mock'; | |||
|
|
|||
| describe('useManagedUserItems', () => { | |||
| describe('useObservedHostFields', () => { | |||
| it('returns managed user items for Entra user', () => { | |||
There was a problem hiding this comment.
nit: maybe update the text below to reference host too?
it('returns managed host items for Entra host', () => {
| * 2.0. | ||
| */ | ||
|
|
||
| export const INSTALL_EA_INTEGRATIONS_HREF = `browse/security?q=entityanalytics`; |
There was a problem hiding this comment.
can this be merged with the other constants in shared folder
There was a problem hiding this comment.
the reason I kept it separate is because this constant is used in a single place within the user_right folder, while the others are used in both user_right and user_left (if I'm not mistaken)
PhilippeOberti
force-pushed
the
manage-user-to-flyout
branch
3 times, most recently
from
553e2a4 to
364c45d
Compare
| }); | ||
|
|
||
| export const FAIL_MANAGED_USER = i18n.translate( | ||
| 'xpack.securitySolution.timeline.userDetails.failManagedUserDescription', |
There was a problem hiding this comment.
I think we should rename the translation keys in this file because they still reference the timeline.
There was a problem hiding this comment.
yup I had missed those. I fixed them as well as another translation file I moved!
PhilippeOberti
force-pushed
the
manage-user-to-flyout
branch
from
364c45d to
9ba2d40
Compare
PhilippeOberti
force-pushed
the
manage-user-to-flyout
branch
from
9ba2d40 to
bec201f
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
This PR continues the effort in removing all old flyout components, hooks and utils functions. It moves all the code related to ManagedUsers hooks, components, types and constants from the timeline side_panel folder to the alert details expandable flyout folder
The goal of this PR is to:
The purpose of the PR was never to full refactor the code, so things that aren't necessarily super clean might still be present.
No UI changes should be visible whatsoever!
Checklist
https://github.com/elastic/security-team/issues/7462