Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): avoid more native modules on production dependencies #190183

Merged
merged 46 commits into from
Aug 23, 2024

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 8, 2024

Closes https://github.com/elastic/kibana-operations/issues/131

This PR is the final step needed for us to re-enable pointer compression on serverless.

It introduces a cli later used in a CI check that will prevent the addition of new native modules on production as discussed and agreed with Luke and Brandon previously.

It also removes the usages of cbor-x and replaces those with a wrapping package @kbn/cbor which relies on the implementation coming from borc with no native modules involved.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.16.0 labels Aug 8, 2024
@elastic elastic deleted a comment from kibana-ci Aug 9, 2024
@mistic mistic requested review from a team as code owners August 14, 2024 01:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@Ikuni17 Ikuni17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@afharo
Copy link
Member

afharo commented Aug 15, 2024

Does this mean that we don't need to install gcc in our docker images?

package.json Show resolved Hide resolved
@mistic
Copy link
Member Author

mistic commented Aug 15, 2024

@afharo I'm not sure if there are other dependencies of it but we might check it later, good thing you remembered us to check it 😃

@mistic mistic force-pushed the avoid-more-native-modules-on-prod branch from a9118b8 to 425dfcc Compare August 22, 2024 04:38
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/cbor - 9 +9
@kbn/yarn-lock-validator 2 4 +2
total +11

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/cbor - 2 +2
Unknown metric groups

API count

id before after diff
@kbn/cbor - 9 +9
@kbn/yarn-lock-validator 6 9 +3
total +12

ESLint disabled line counts

id before after diff
@kbn/check-prod-native-modules-cli - 17 +17

Total ESLint disabled count

id before after diff
@kbn/check-prod-native-modules-cli - 17 +17

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 433cc1e into elastic:main Aug 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.