-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): avoid more native modules on production dependencies #190183
chore(NA): avoid more native modules on production dependencies #190183
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Does this mean that we don't need to install gcc in our docker images? |
@afharo I'm not sure if there are other dependencies of it but we might check it later, good thing you remembered us to check it 😃 |
a9118b8
to
425dfcc
Compare
This reverts commit 6053de0.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Any counts in public APIs
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Closes https://github.com/elastic/kibana-operations/issues/131
This PR is the final step needed for us to re-enable pointer compression on serverless.
It introduces a cli later used in a CI check that will prevent the addition of new native modules on production as discussed and agreed with Luke and Brandon previously.
It also removes the usages of
cbor-x
and replaces those with a wrapping package@kbn/cbor
which relies on the implementation coming fromborc
with no native modules involved.