Unskip Dashboard to TSVB to Lens should convert a by reference #190230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Feature:TSVB
mbondyra
force-pushed
the
lens/fix_tsvb_to_lens
branch
from
ca7db42 to
25a5bac
Compare
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
approved these changes
Aug 9, 2024
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6733[✅] x-pack/test/functional/apps/lens/open_in_lens/tsvb/config.ts: 200/200 tests passed. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 12, 2024
…ic#190230) ## Summary Fixes elastic#179307 What I suspect happening is that some 'ghost' click is somehow happening outside of the panel settings area (that should be open the point where tests breaks, but the screenshot shows it's closed) and that's why it is closed. Adding a retry around the whole panel settings actions should help, but let's keep an eye on it. <img width="1100" alt="Screenshot 2024-08-09 at 13 44 20" src="https://github.com/user-attachments/assets/17d61852-c371-453d-9f41-46fd52f9e384"> The flakiness is rare so not sure if running the flaky test runner makes sense, but I'd do it anyway: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6733 (cherry picked from commit bb73fc4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 12, 2024
…#190230) (#190353) # Backport This will backport the following commits from `main` to `8.15`: - [Unskip Dashboard to TSVB to Lens should convert a by reference (#190230)](#190230) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-08-12T18:46:20Z","message":"Unskip Dashboard to TSVB to Lens should convert a by reference (#190230)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/179307\r\n\r\nWhat I suspect happening is that some 'ghost' click is somehow happening\r\noutside of the panel settings area (that should be open the point where\r\ntests breaks, but the screenshot shows it's closed) and that's why it is\r\nclosed. Adding a retry around the whole panel settings actions should\r\nhelp, but let's keep an eye on it.\r\n\r\n\r\n<img width=\"1100\" alt=\"Screenshot 2024-08-09 at 13 44 20\"\r\nsrc=\"https://github.com/user-attachments/assets/17d61852-c371-453d-9f41-46fd52f9e384\">\r\n\r\nThe flakiness is rare so not sure if running the flaky test runner makes\r\nsense, but I'd do it anyway:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6733","sha":"bb73fc41bd5cc2abb99479442e62148546c37fbb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.16.0","v8.15.1"],"title":"Unskip Dashboard to TSVB to Lens should convert a by reference","number":190230,"url":"https://github.com/elastic/kibana/pull/190230","mergeCommit":{"message":"Unskip Dashboard to TSVB to Lens should convert a by reference (#190230)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/179307\r\n\r\nWhat I suspect happening is that some 'ghost' click is somehow happening\r\noutside of the panel settings area (that should be open the point where\r\ntests breaks, but the screenshot shows it's closed) and that's why it is\r\nclosed. Adding a retry around the whole panel settings actions should\r\nhelp, but let's keep an eye on it.\r\n\r\n\r\n<img width=\"1100\" alt=\"Screenshot 2024-08-09 at 13 44 20\"\r\nsrc=\"https://github.com/user-attachments/assets/17d61852-c371-453d-9f41-46fd52f9e384\">\r\n\r\nThe flakiness is rare so not sure if running the flaky test runner makes\r\nsense, but I'd do it anyway:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6733","sha":"bb73fc41bd5cc2abb99479442e62148546c37fbb"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190230","number":190230,"mergeCommit":{"message":"Unskip Dashboard to TSVB to Lens should convert a by reference (#190230)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/179307\r\n\r\nWhat I suspect happening is that some 'ghost' click is somehow happening\r\noutside of the panel settings area (that should be open the point where\r\ntests breaks, but the screenshot shows it's closed) and that's why it is\r\nclosed. Adding a retry around the whole panel settings actions should\r\nhelp, but let's keep an eye on it.\r\n\r\n\r\n<img width=\"1100\" alt=\"Screenshot 2024-08-09 at 13 44 20\"\r\nsrc=\"https://github.com/user-attachments/assets/17d61852-c371-453d-9f41-46fd52f9e384\">\r\n\r\nThe flakiness is rare so not sure if running the flaky test runner makes\r\nsense, but I'd do it anyway:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6733","sha":"bb73fc41bd5cc2abb99479442e62148546c37fbb"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #179307
What I suspect happening is that some 'ghost' click is somehow happening outside of the panel settings area (that should be open the point where tests breaks, but the screenshot shows it's closed) and that's why it is closed. Adding a retry around the whole panel settings actions should help, but let's keep an eye on it.
The flakiness is rare so not sure if running the flaky test runner makes sense, but I'd do it anyway: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6733