[Fleet] change UX of edit integration policy agent policies

[juliaElastic]

Summary

Closes #186629

Changed UX of edit integration policy page to update agent policies.

To verify:

• Add integration or create new agent policy with system integration
• Edit the integration policy
• Verify that the UI allows adding new agent policy with making changes to existing agent policies

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios

[juliaElastic]

/ci

[obltmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[jen-huang]

I think the "Advanced options" toggle should still be removed for new agent policy. Could you fix it in this PR?

Also, I am touching the logic around the confirmation state/modal in #190649 so it will probably be better for this one to get merged first and I'll update my PR afterwards.

[juliaElastic]

I think the "Advanced options" toggle should still be removed for new agent policy. Could you fix it in this PR?

I removed the Advanced options section from Edit and Add integration pages, it doesn't affect the create agent policy flyout.

[nchaulet]

could we search directly for non managed policies in the API call with a kuery like not is_managed:* or is_managed:false (not tested)?

[juliaElastic]

I tried that but it didn't work. I think is_managed is not indexed: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/core/template-resources/src/main/resources/fleet-agents.json

[nchaulet]

it should be indexed https://github.com/juliaElastic/kibana/blob/22c3f95868d6a5d804e9ed85b7575da6dd423b46/x-pack/plugins/fleet/server/saved_objects/index.ts#L282 but not a blocker it should not really change the number of policies returned as we do not expect to have many managed policies

[juliaElastic]

You are right, I was looking at the wrong place.
The filter actually works, I tried before without the prefix ingest-agent-policies.is_managed:false

[nchaulet]

Tested locally and worked as expected 🚀

[juliaElastic]

/ci

[juliaElastic]

/ci

[juliaElastic]

/ci

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: be2ae3c

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
fleet	1213	1215	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
fleet	1.8MB	1.8MB	+1.7KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
fleet	44	45	+1

Total ESLint disabled count

id	before	after	diff
fleet	57	58	+1

History

• 💔 Build #230490 failed be2ae3c
• 💔 Build #230467 failed be2ae3c
• 💔 Build #230459 failed be2ae3c
• 💔 Build #230445 failed be2ae3c
• 💚 Build #230368 succeeded 22c3f95
• 💔 Build #230342 failed 6195819

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic