-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] search_indices: scaffold empty plugin #190748
[Search] search_indices: scaffold empty plugin #190748
Conversation
0b24897
to
e759373
Compare
e759373
to
9825b80
Compare
9825b80
to
d823150
Compare
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
A general thought: declaring dependencies before being actively used might end up with those dependencies never being removed.
IIRC, the long-term plan is to add a CI step that checks that dependencies are used. Although it's not completed yet 😇
@@ -30,6 +30,7 @@ | |||
"indexManagement", | |||
"searchConnectors", | |||
"searchHomepage", | |||
"searchIndices", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: since the plugin doesn't export any contract yet, I'd hold off declaring the dependency unless there's any specific reason to force a certain order in the execution of the plugins.
Summary
Scaffolding empty plugin for development of day 0 onboarding work. This plugin is currently disabled by default and will be enabled for ES3 when it's ready for users.