Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] search_indices: scaffold empty plugin #190748

Merged

Conversation

TattdCodeMonkey
Copy link
Contributor

Summary

Scaffolding empty plugin for development of day 0 onboarding work. This plugin is currently disabled by default and will be enabled for ES3 when it's ready for users.

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 labels Aug 19, 2024
@TattdCodeMonkey TattdCodeMonkey requested review from a team as code owners August 19, 2024 22:01
@TattdCodeMonkey TattdCodeMonkey force-pushed the search-indices/plugin-setup branch from 0b24897 to e759373 Compare August 20, 2024 14:37
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner August 20, 2024 14:37
@TattdCodeMonkey TattdCodeMonkey force-pushed the search-indices/plugin-setup branch from e759373 to 9825b80 Compare August 20, 2024 15:17
@TattdCodeMonkey TattdCodeMonkey requested review from a team and removed request for a team August 20, 2024 15:17
@TattdCodeMonkey TattdCodeMonkey force-pushed the search-indices/plugin-setup branch from 9825b80 to d823150 Compare August 20, 2024 17:00
@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) August 21, 2024 20:34
@TattdCodeMonkey
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchIndices - 4 +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
searchIndices - 6 +6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchIndices - 1.5KB +1.5KB
Unknown metric groups

API count

id before after diff
searchIndices - 6 +6

ESLint disabled line counts

id before after diff
searchIndices - 4 +4

Total ESLint disabled count

id before after diff
searchIndices - 4 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A general thought: declaring dependencies before being actively used might end up with those dependencies never being removed.

IIRC, the long-term plan is to add a CI step that checks that dependencies are used. Although it's not completed yet 😇

@@ -30,6 +30,7 @@
"indexManagement",
"searchConnectors",
"searchHomepage",
"searchIndices",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since the plugin doesn't export any contract yet, I'd hold off declaring the dependency unless there's any specific reason to force a certain order in the execution of the plugins.

@TattdCodeMonkey TattdCodeMonkey merged commit e6e75ef into elastic:main Aug 23, 2024
42 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants