-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][DQD][Tech Debt] Colocate components #190978
Merged
kapral18
merged 13 commits into
elastic:main
from
kapral18:improve/DQD/190964-tech-debt-cleanup-2
Aug 26, 2024
Merged
[Security Solution][DQD][Tech Debt] Colocate components #190978
kapral18
merged 13 commits into
elastic:main
from
kapral18:improve/DQD/190964-tech-debt-cleanup-2
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapral18
added
technical debt
Improvement of the software architecture and operational architecture
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting
Security Solution Threat Hunting Team
Team:Threat Hunting:Explore
v8.16.0
labels
Aug 21, 2024
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
kapral18
changed the title
[Security Solution][DQD][Tech Debt] Restructure
[Security Solution][DQD][Tech Debt] Colocate components
Aug 21, 2024
kapral18
force-pushed
the
improve/DQD/190964-tech-debt-cleanup-2
branch
from
August 21, 2024 20:41
c67198f
to
8a2e192
Compare
kapral18
force-pushed
the
improve/DQD/190964-tech-debt-cleanup-2
branch
from
August 22, 2024 18:26
a1da4c8
to
f4dd942
Compare
kapral18
force-pushed
the
improve/DQD/190964-tech-debt-cleanup-2
branch
from
August 23, 2024 23:20
f4dd942
to
7aba7ce
Compare
semd
approved these changes
Aug 26, 2024
addresses elastic#190964 First in the series of PRs to address general DQD tech debt This one flattens and makes structure a little more logical - rename top level data_quality/ folder to data_quality_panel/ in line with the actual component name in index.tsx - remove redundant nested data_quality_panel/ folder
- Moved CheckStatus component under SummaryAction component - Moved ErrorsViewer and ErrorsPopover components under `summary_actions/check_status`.
- remove body component and incorporate it into parent - refactor data_quality_panel tests to incorporate the aforementioned change
- move IlmPhaseEmptyPrompt component - move ErrorEmptyPrompt component - move LoadingEmptyPrompt component - move IndexResultBadge component
kapral18
force-pushed
the
improve/DQD/190964-tech-debt-cleanup-2
branch
from
August 26, 2024 10:41
7aba7ce
to
07fcb76
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @kapral18 |
kapral18
added a commit
that referenced
this pull request
Aug 28, 2024
…1245) addresses #190964 Fourth in the series of PRs to address general DQD tech debt This one builds on previous 3 PRs #190970 #190978 #191233 Gist of changes: split lower level helpers into series of utils/* files each utils/ file is named after common behavior it export or works with. cleanup dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting:Explore
Team:Threat Hunting
Security Solution Threat Hunting Team
technical debt
Improvement of the software architecture and operational architecture
v8.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #190964
Second in the series of PRs to address general DQD tech debt. Currently this PR build on the work of #190970.
So this PR restructures components to colocate component throughout the hierarchy.
So instead of:
we use:
PROs of such scaffold:
CONS:
../../../../../../../../../
. It is fixable by ts paths/webpack aliases, but on the other hand especially if there are many of those it's an indication of potential architectural smell, that needs to be addressed (which is a PRO).Imho, overall visibility trumps any cons and facilitates greater ease of adding new and changing existing functionality with more confidence.
Before
After