Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controls] Refactor control group settings functional tests #190999

Merged
merged 9 commits into from
Aug 22, 2024
Merged

[controls] Refactor control group settings functional tests #190999

merged 9 commits into from
Aug 22, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 21, 2024 •
edited
Loading

Refactor control group settings tests

  1. move non-functional test cases to unit tests
  2. use pre-built dashboard to avoid time of building dashboard in test

Before

Tests take 4 minutes to run locally
Screenshot 2024-08-21 at 3 12 31 PM

After

Tests take 1 minute to run locally
Screenshot 2024-08-21 at 2 53 37 PM

@nreese
Copy link
Contributor Author

nreese commented Aug 21, 2024

/ci

1 similar comment
@nreese
Copy link
Contributor Author

nreese commented Aug 21, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Aug 21, 2024

/ci

@nreese nreese changed the title Refactor Control settings test [controls] Refactor control group settings functional tests Aug 21, 2024
@nreese nreese marked this pull request as ready for review August 22, 2024 00:43
@nreese nreese requested a review from a team as a code owner August 22, 2024 00:43
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Aug 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Aug 22, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 379.4KB 379.4KB +35.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ThomThomson
ThomThomson approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes LGTM! Looked through the tests to ensure that all test coverage was retained. Great to see functional tests get converted into unit tests, and great to see the reduction in CI time.

src/plugins/controls/public/react_controls/control_group/components/control_group_editor.tsx
@@ -46,21 +46,15 @@ const CONTROL_LAYOUT_OPTIONS = [
},
];

interface EditControlGroupProps {
interface Props {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if this type isn't exported or used more than once - why not inline it?

@nreese nreese merged commit 79051d4 into elastic:main Aug 22, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nreese @elasticmachine @kibana-ci @ThomThomson @kibanamachine