[Cloud Security] fix 'show 1 alerts' bug #191062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcold
added
release_note:skip
JordanSh
reviewed
Aug 22, 2024
| values={{ | ||
| count: <strong>{totalAlertsCount}</strong>, | ||
| count: totalAlertsCount, | ||
| bold: (str: string) => <strong>{str}</strong>, |
There was a problem hiding this comment.
before and after image for that could be nice
There was a problem hiding this comment.
I don't have a quick way to have session view data in my local env, but check the unit test, it should cover it, at least the text is there. The markup should work as well, taken straight from the docs https://formatjs.io/docs/react-intl/components#rich-text-formatting. But if we have a quick way to have the session view in local, happy to test it manually
JordanSh
approved these changes
Aug 22, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using plural from
react-intlin the Session View forShow N alertstext