Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inference] Minor cleanup and restructure #191069

Merged
merged 14 commits into from
Aug 26, 2024
Merged

[Inference] Minor cleanup and restructure #191069

merged 14 commits into from
Aug 26, 2024

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Aug 22, 2024 •
edited
Loading

Summary

Fixing and improving a few things I noticed while discovering / ramping up on the existing code

  • address some nits
  • extract / reuse some low level functions
  • move things around
  • add unit tests

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 Team:AI Infra AppEx AI Infrastructure Team labels Aug 22, 2024
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet marked this pull request as ready for review August 23, 2024 07:46
@pgayvallet pgayvallet requested review from a team as code owners August 23, 2024 07:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-ai-infra (Team:AI Infra)

YulNaumenko
YulNaumenko approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
inference 5.2KB 5.2KB +24.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 56730e8 into elastic:main Aug 26, 2024
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@legrego legrego legrego approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:AI Infra AppEx AI Infrastructure Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pgayvallet @elasticmachine @kibana-ci @dgieselaar @legrego @YulNaumenko @kibanamachine