fix: remove deprecated squid filebeat module tutorial from integrations #191115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoutsovasilis
added
the
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Hi @afharo 👋 do we need to backport this one to 8.15 as well? |
Good question! I think that the changes are minimal enough that should be safe to backport (especially given that the modules were removed in 8.14). |
pkoutsovasilis
added
v8.14.4
v8.15.1
backport:version
sorry but I am not quite familiar with the backporting process in this repo 😅 are my labels correct? |
|
We only backport to the previous minor (and/or major, but it doesn't apply here). I've corrected the labels to do so. Once back ported & merged, the CI will add the versions that this PR will be released in. |
afharo
added
backport:prev-minor
|
Pinging @elastic/kibana-core (Team:Core) |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
afharo
pushed a commit
to afharo/kibana
that referenced
this pull request
Aug 23, 2024
…ns (elastic#191115) ## Summary This PR removes the deprecated `squid` integration based on the Filebeat module (deprecation issue [here](elastic/beats#37746)). Instead, as of now, a user that wants to use the `squad` integration needs to tick the `Display beta integrations` and install the "new" squid integration ### Risk Matrix N/A ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit bd9dde8) # Conflicts: # x-pack/plugins/translations/translations/fr-FR.json # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
afharo
added a commit
that referenced
this pull request
Aug 23, 2024
…egrations (#191115) (#191195) # Backport This will backport the following commits from `main` to `8.15`: - [fix: remove deprecated squid filebeat module tutorial from integrations (#191115)](#191115) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Panos Koutsovasilis","email":"panos.koutsovasilis@elastic.co"},"sourceCommit":{"committedDate":"2024-08-23T13:47:49Z","message":"fix: remove deprecated squid filebeat module tutorial from integrations (#191115)\n\n## Summary\n\nThis PR removes the deprecated `squid` integration based on the Filebeat\nmodule (deprecation issue\n[here](elastic/beats#37746)). Instead, as of\nnow, a user that wants to use the `squad` integration needs to tick the\n`Display beta integrations` and install the \"new\" squid integration\n\n\n### Risk Matrix\n\nN/A\n\n\n### For maintainers\n\n- [ ] This was checked for breaking API changes and was [labeled\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"bd9dde8ba749a33a1d5b56dff77d2e47c6e7e17c","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Team:Integrations","backport:prev-minor","v8.16.0"],"number":191115,"url":"https://github.com/elastic/kibana/pull/191115","mergeCommit":{"message":"fix: remove deprecated squid filebeat module tutorial from integrations (#191115)\n\n## Summary\n\nThis PR removes the deprecated `squid` integration based on the Filebeat\nmodule (deprecation issue\n[here](elastic/beats#37746)). Instead, as of\nnow, a user that wants to use the `squad` integration needs to tick the\n`Display beta integrations` and install the \"new\" squid integration\n\n\n### Risk Matrix\n\nN/A\n\n\n### For maintainers\n\n- [ ] This was checked for breaking API changes and was [labeled\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"bd9dde8ba749a33a1d5b56dff77d2e47c6e7e17c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191115","number":191115,"mergeCommit":{"message":"fix: remove deprecated squid filebeat module tutorial from integrations (#191115)\n\n## Summary\n\nThis PR removes the deprecated `squid` integration based on the Filebeat\nmodule (deprecation issue\n[here](elastic/beats#37746)). Instead, as of\nnow, a user that wants to use the `squad` integration needs to tick the\n`Display beta integrations` and install the \"new\" squid integration\n\n\n### Risk Matrix\n\nN/A\n\n\n### For maintainers\n\n- [ ] This was checked for breaking API changes and was [labeled\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"bd9dde8ba749a33a1d5b56dff77d2e47c6e7e17c"}}]}] BACKPORT--> --------- Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the deprecated
squidintegration based on the Filebeat module (deprecation issue here). Instead, as of now, a user that wants to use thesquadintegration needs to tick theDisplay beta integrationsand install the "new" squid integrationRisk Matrix
N/A
For maintainers