Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security][Quick Wins] Fix for Field Selector issue #191130

Merged
merged 2 commits into from
Aug 23, 2024
Merged

[Cloud Security][Quick Wins] Fix for Field Selector issue #191130

merged 2 commits into from
Aug 23, 2024

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Aug 22, 2024 •
edited
Loading

Summary

This PR is to address issue where whenever user tries to check on the field on the field selector outside the 1st page, user will be navigated to the 1st page upon checking the checkbox.

Screen.Recording.2024-08-22.at.12.32.27.PM.mov

Steps to test:

  • Get some findings data in
  • Navigate to Findings Page
  • Group by None
  • Click on Fields selector, navigate to other pages
  • Check on any of field checkboxes

Expected Result:
User should not get navigated back to page 1

@animehart animehart linked an issue Aug 22, 2024 that may be closed by this pull request
[Bug][Findings] Findings table field selector modal does not keep the current page after selecting a field #181754
Closed
@animehart animehart marked this pull request as ready for review August 22, 2024 19:36
@animehart animehart requested a review from a team as a code owner August 22, 2024 19:36
@animehart
Copy link
Contributor Author

/ci

@animehart animehart added v8.16.0 Team:Cloud Security Cloud Security team related labels Aug 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart animehart added the release_note:skip Skip the PR/issue when compiling release notes label Aug 22, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 480.2KB 480.3KB +92.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

opauloh
opauloh approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@animehart animehart merged commit 7ffdd1b into elastic:main Aug 23, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opauloh opauloh opauloh approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][Findings] Findings table field selector modal does not keep the current page after selecting a field
5 participants
@animehart @elasticmachine @kibana-ci @opauloh @kibanamachine